search

tomojitakasu / RTKLIB

2.51k stars 1.6k forks source link

satazel is buggy #483

Closed shiluotang closed 5 years ago

shiluotang commented 5 years ago

image

As the image describes, if ECEF-z is no larger than RE_WGS84, then the yield elevation will be 90 degrees. This is definitely not right!

tomojitakasu commented 5 years ago

See the header comments of the API. The pos[2] does not show ECEF-Z but ellipsoidal height.

YangY-Yang commented 5 years ago

I think it is a minus RE_WG84, if not larger than it, then will set the elevation to 90. Pretty fair

yydgis commented 5 years ago

You did not fully understand the principle of the design logic. Based on my understanding, in this case, there is no approximate coordinates of the station, then all the satellite elevations are PI/2.0, then it is equally weight for all satellites, this is only used in the initial case. Yudan

On Mon, Aug 26, 2019 at 2:10 AM shiluotang notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/3193750/63679509-0896f700-c824-11e9-9033-8c6559e9ad39.png

As the image describes, if ECEF-z is no larger than RE_WGS84, then the yield elevation will be 90 degrees. This is definitely not right!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tomojitakasu/RTKLIB/issues/483?email_source=notifications&email_token=AD6QBIZPPC3RLN7OSZ64LMLQGOMZVA5CNFSM4IPNR7RKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHKRCQA, or mute the thread https://github.com/notifications/unsubscribe-auth/AD6QBI7D7XNBFEHYDZK6UZLQGOMZVANCNFSM4IPNR7RA .

shiluotang commented 5 years ago

See the header comments of the API. The pos[2] does not show ECEF-Z but ellipsoidal height.

Thanks for you suggestion! It's my fault! I was misled by the method name ecef2enu which made me took pos parameter as ECEF coordinate is actually BLH thing.

By the way, the name "ecef2enu" is really easy to confuse rookies.