search

tomojitakasu / RTKLIB

2.58k stars 1.63k forks source link

Deletion of old API, STR_NTRIPC_S, also needs modifications of rtkrcv.c and naviopt.cpp #638

Open yoronneko opened 2 years ago

yoronneko commented 2 years ago

Issue: The app rtkrcv with an input stream type of NTRIP client fails. The app RTKNAVI with NTRIP client stream type produces a configuration file with the undetermined stream type of 6.

Suggestion: We need modifications in app/consapp/rtkrcv/rtkrcv.c and app/winapp/rtknavi/naviopt.cpp reflecting the old API deletion of STR_NTRIPC_S in src/stream.c and the API renumbering in src/rtklib.h .

Description: The definitions of ISTOPT and OSTOPT in app/consapp/rtkrcv/rtkrcv.c and app/winapp/rtknavi/naviopt.cpp are used not only for the help message, but also for parsing the configuration file. The configuration is performed calling functions of searchopt(), loadopts(), and saveopts().

As partially mentioned in an issue https://github.com/tomojitakasu/RTKLIB/issues/569#issuecomment-762212548 , we require updating ISTOPT and OSTOPT.

I also suggest moving the definitions of TIMOPT, CONOPT, FLGOPT, ISTOPT, OSTOPT, FMTOPT, NMEOPT, SOLOPT, and MSGOPT to rtklib.h for further maintenance.

I acknowledge your long efforts and I love RTKLIB.