search

tomoki1207 / vscode-pdfviewer

Show PDF preview in VSCode.
https://marketplace.visualstudio.com/items/tomoki1207.pdf
Other
295 stars 70 forks source link

Run extension locally when using remote development #100

Closed kfigiela closed 1 year ago

kfigiela commented 3 years ago

This extension has to execute in ui and not workspace (default) in order to work properly with VSCode Remote development (i.e. SSH, Docker, WSL), as described in https://code.visualstudio.com/api/advanced-topics/remote-extensions#incorrect-execution-location

Without this change nothing is visible in the UI (blank tab).

As a temporary workaround one may add to VSCode settings:


  "remote.extensionKind": {
    "tomoki1207.pdf": ["ui"],
  }
}
mcsitter commented 2 years ago

Without this change nothing is visible in the UI (blank tab).

When using a Dev Container this also happens to me. Is there anything preventing this merge? I'd highly appreciate the change. Thank you for finding and implementing the solution @kfigiela

The document i have opened in this screenshot can be opened outside the remote container without any issues. Adding the lines from above to settings.json is a workaround for the time being.

image