tomoki1207 / vscode-pdfviewer

Show PDF preview in VSCode.
https://marketplace.visualstudio.com/items/tomoki1207.pdf
Other
295 stars 70 forks source link

Allow pdf viewer to work in an untrusted workspace #102

Closed lramos15 closed 2 years ago

lramos15 commented 3 years ago

Hello :wave: I'm from the VS Code team.

Recently, we have been exploring a security feature we refer to as Workspace Trust. This feature is intended to centralize and unify a security conscious decision required by a variety of VS Code features. With workspace trust, the user will be able to declare whether or not they trust the folder that is opened in VS Code before these features are executed. A detailed guide regarding workspace trust can be found in issue #120251.

Why you should care

Custom editors rely on an extension host based model which means that if your extension cannot activate in an untrusted scenario then things like restoring, and general operation will not work. This can lead to a bad user experience or even data loss.

After reviewing your codebase, I believe that the extension doesn't assume any workspace content is code and therefore it is ok to operate in the untrusted state. Let me know if you have any questions and I would be happy to assist. The hope is to turn workspace trust on by default in the next release of VS Code so please let me know if there's anything blocking you from merging this PR.

tomoki1207 commented 2 years ago

Thanks.