search

tomoki1207 / vscode-pdfviewer

Show PDF preview in VSCode.
https://marketplace.visualstudio.com/items/tomoki1207.pdf
Other
294 stars 69 forks source link

Upgrade PDF.js to 2.13.216 #131

Open x11x opened 2 years ago

x11x commented 2 years ago

I followed the helpful instructions in the readme. I had to use "Prebuilt (for older browsers)" bundle - maybe this should be mentioned in readme? The main "Prebuilt" bundle had issues with new structuredClone API support (and possibly other issues I did not notice). But these issues should go away eventually if/when vscode updates its JS engine.

ericsia commented 2 years ago

@x11x just curious, I notice the developer switch from typescript to javascript, do you know why he do this? Btw did I saw u are maintaining actively, did u published it?

x11x commented 2 years ago

Do you mean pdf.js used to be typescript? Sorry, I couldn't tell you, I'm not familiar with that project. No, I haven't published it, just built a vsix file to test. I don't think I will be doing much maintaining in my fork other than maybe updating pdfjs Maybe I could publish it if this project is no longer maintained.