search

tomoki1207 / vscode-pdfviewer

Show PDF preview in VSCode.
https://marketplace.visualstudio.com/items/tomoki1207.pdf
Other
294 stars 69 forks source link

Disable the `Ctrl` + `Shift` + `P` keybinding from printing #132

Open shahaqsta opened 2 years ago

shahaqsta commented 2 years ago

Thank you so much for a very useful extension!

Is there any way to disable the Ctrl + Shift + P keybinding from printing? I would like to use it strictly for opening the VS code command palette and not print the pdf.

MStachowicz commented 11 months ago

Unfortunately I am searching for an alternative because of this.

Its a real pain the ass as it clashes with Ctrl + P (open file), meaning if I tab into a PDF, I have to tab out and then ctrl + P. If I only have a PDF open I am trapped inside it and have to close it. @tomoki1207 please advise where I can look in code to disable this Im not familiar with the code but happy to try removing it.

oscartorres-10 commented 11 months ago

Hey, this is also an issue for me. I'm very used to my workflow of CMD + P and CMD+SHIFT+P on VS Code.

I'll probably won't be using the extension until this is resolved.

Apart from that, it works great! Thanks for your work.

oscartorres-10 commented 11 months ago

An alternative that doesn't have this issue, but I noticed it has a delay on a gray screen for a moment before showing the content. It happens when switching between PDFs also.

Name: PDF Viewer Id: mathematic.vscode-pdf Description: Portable document format (PDF) viewer for Visual Studio Code. Version: 0.0.6 Publisher: Mathematic Inc VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=mathematic.vscode-pdf

alonso-herreros commented 6 months ago

Please fix this. Why would I want to print a PDF file from VS Code using the shortcut for opening the Command Palette. The place where you can find any other action in all of VS Code is unavoidably replaced by a PDF print function. It's not even registered as a shortcut. This is a deal breaker.