search

tomoki1207 / vscode-pdfviewer

Show PDF preview in VSCode.
https://marketplace.visualstudio.com/items/tomoki1207.pdf
Other
311 stars 75 forks source link

Support for pdf links with named destinations #140

Open przemech opened 2 years ago

przemech commented 2 years ago

This adds support for named destinations described here:

https://github.com/mozilla/pdf.js/issues/5258#issuecomment-54633345

This also solves following issues:

przemech commented 2 years ago

This will work only with absolute filepath links: file:///<absolute_path>/<filename>.pdf#<named_destination>

When using a relative path in the vscode, the path is resolved and the #<named_destination> is trimmed, so it gets lost before it reaches extension's code. Anyway, such link will not work on a GitHub repo, so proposed change is just a minor feature.

JBoysen1 commented 11 months ago

Yes - we need this. I use similar command line calls to open pdf in browsers. What would the VS code syntax on the command line look like ?