tomoki1207 / vscode-pdfviewer

Show PDF preview in VSCode.
https://marketplace.visualstudio.com/items/tomoki1207.pdf
Other
294 stars 69 forks source link

Only allows local install #150

Open nianeyna opened 1 year ago

nianeyna commented 1 year ago

I used to be able to use this on my code-server instance, but now it is broken and when I go to the extension page it only gives me the option to "Install Locally" which won't work for me - I need to be able to install it on the server.

Weissnix4711 commented 1 year ago

Sometimes installing from vsix can break code-server and trick it into allowing the extension to be installed anyway. It's really not a permanent solution at all though.

I have used this extension on code-server too though, and can vouch for it running just fine (when it can be installed). I believe all it requires is a small change to the package manifest for it to be installable again, so I'm hoping it won't be too hard to fix.

Weissnix4711 commented 1 year ago

This change seems to be the culprit: https://github.com/tomoki1207/vscode-pdfviewer/commit/1f1c9c849425a4e0b7ecb2284748423746c79551

As per the extension host docs, "extensionKind": ["ui"] disables the extension on code-server.