tomoki1207 / vscode-pdfviewer

Show PDF preview in VSCode.
https://marketplace.visualstudio.com/items/tomoki1207.pdf
Other
295 stars 70 forks source link

Sometimes I have to confirm opening "The file is not displayed in the editor because..." #26

Closed gandalfsaxe closed 4 years ago

gandalfsaxe commented 6 years ago

For some PDFs this text comes up and I have to confirm every time I want to open a PDF:

The file is not displayed in the editor because it is either binary or uses an unsupported text encoding. Do you want to open it anyway?

For others PDFs it opens without having to confirm.

This seems related to Microsoft/vscode/issues/1218. Would it be possible for you to simply open PDFs every time without having to confirm? Otherwise I guess we'll need to make an issue with Microsoft/vscode.

To illustrate, some works fine:

Others does not:

tomoki1207 commented 4 years ago

Because change api for display preview, it might be resolved.