tomoki1207 / vscode-pdfviewer

Show PDF preview in VSCode.
https://marketplace.visualstudio.com/items/tomoki1207.pdf
Other
295 stars 70 forks source link

Key combination ([Ctrl] + [W]) tries to close more than 1 window #51

Closed Nikolice closed 4 years ago

Nikolice commented 4 years ago

Issue Type: Bug

Maybe that's not an extension-specific problem… I don't know.

My set: OS “Simply Linux” by “BaseALT” of Russian Federation (with an “XFCE desktop environment”), and “VS Code Insiders” (with an extension “vscode-pdf”). Not tested in “Windows 10”.

To reproduce:

  1. Have some windows opened (three of them): → Some files (two of them). Both – with unsaved changes; → A view of a “PDF”-file (not its “code”) – opened by an “vscode-pdf” extension.

  2. Try to close the window of the “PDF”-file – by pressing a key-combination: [Ctrl]+[W].

As a result – a dialog appears, asking: “Whether to save the contents of one of the previous windows (where, some unsaved changes were)?”

So, my question is: should the [Ctrl]+[W] ask to close more than one window?


Though, if I go to a “File” menu (of the “VS Code”) – I see: [Ctrl]+[W] → can close (either?):

If I click on the “Close” cross (icon button) of the “VS Code - PDF” window tab (at the inside – of the “VS Code” opened window tabs bar) – only one window closes, without asking to close something else.


Extension version: 0.5.1 VS Code version: Code - Insiders 1.41.0-insider (a747d264d668a947eeacd3492b60df6ce8dee6b4, 2019-11-23T11:12:35.768Z) OS version: Linux x64 4.19.72-std-def-alt1

System Info |Item|Value| |---|---| |CPUs|AMD A4-4020 APU with Radeon(tm) HD Graphics (2 x 2966)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: disabled_off
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|1, 1, 1| |Memory (System)|3.31GB (0.41GB free)| |Process Argv|--no-sandbox --unity-launch| |Screen Reader|no| |VM|0%|
Nikolice commented 4 years ago

Tried it now in "Windows 10" with usual (non-insiders) version of "VS Code" – and got no problem.

tomoki1207 commented 4 years ago

OK, please reopen when it is occurred again. Thanks for information.