search

tomouchuu / mastodon-translate

Tampermonkey Script to add option to Translate Toots
The Unlicense
24 stars 2 forks source link

Investigate why some users are unable to save their settings #8

Closed tomouchuu closed 7 years ago

tomouchuu commented 7 years ago

Have had two people reach out to me to say the script isn't working for them. Am unable to reproduce the issue on my computers/browsers. The first instance was a person's translation language not being set and the second was a person unable to set the checkbox to true to agree.

The most likely cause seems to be some sort of issue with GM_setValue not setting.

tomouchuu commented 7 years ago

Wondered if there could be a potential browser/version of tamperfork issue, nothing on the comparison chart: https://github.com/scriptish/scriptish/wiki/Comparison-Table. And had to download tamperfork on my work firefox/edge browsers and it's working there.

tomouchuu commented 7 years ago

Interesting, on safari tampermonkey am getting an issue with content-security-policy: Refused to execute a script because its hash, its nonce, or 'unsafe-inline' does not appear in the script-src directive of the Content Security Policy. I'm not sure this is related as not even seeing the script, but could be worth considering.

tomouchuu commented 7 years ago

Person who is unable to set checkbox is using Windows 10 & Chrome. Had no issues on this platform at work so very confusing

tomouchuu commented 7 years ago

Still issue apparently 🙁

tomouchuu commented 7 years ago

Using a hardcoded script isn't ideal but could maybe shine a light on the script not being able to save, since if this doesn't work then I'm not sure it's an issue with setting preferences.

hetima commented 7 years ago

textContent of save button depends on language setting. In some cases event.target.textContent === 'Save changes' return false.

tomouchuu commented 7 years ago

Wow, this makes a ton of sense, don't see how I missed it earlier. Will be working on this tonight, thanks @hetima !