search

tomoyu719 / simple_sheet_music

A Flutter package for rendering sheet music.
https://pub.dev/packages/simple_sheet_music
MIT License
10 stars 6 forks source link

Fix for LateInitializationError during rebuild of parent widget. #20

Closed beattizzle closed 1 month ago

tomoyu719 commented 1 month ago

@beattizzle Thank you very much for your commitment and dedication.

tomoyu719 commented 1 month ago

close #19

lukasnalezenec commented 1 month ago

That is interesting. This shouldn't happen unless the Future fails. Maybe there's an issue with assets in your project setup?

To test it, you could write a simple Flutter component test to see what’s going on. Will send you some example.

Also, I think those two fields shouldn’t be in the class, and their values should be passed into the Future instead.

` late final GlyphPaths glyphPath;

late final GlyphMetadata metadata; `

I fixed another issue where the load method can take up to 700 milliseconds. How long does it take in your app? It might be better to load the font info at app startup instead of during component initialization.

lukasnalezenec commented 1 month ago

Btw, Check this PR https://github.com/tomoyu719/simple_sheet_music/pull/18/commits

@tomoyu719 @beattizzle

beattizzle commented 1 month ago

@tomoyu719, I appreciate your work putting this project together! It is exactly what I need for my music theory app. And thank you for addressing my PR so quickly.

@lukasnalezenec, I did not see your PR when combing through issues in the repo, but it appears to be implementing the same solution I have in mine (along with your optimizations). Your other changes make sense to me.

In my app, it is taking 101.79ms for load() to run based on the performance view metrics.

performanceView