search

tomoyu719 / simple_sheet_music

A Flutter package for rendering sheet music.
https://pub.dev/packages/simple_sheet_music
MIT License
10 stars 6 forks source link

Respect ancestor onTap event. #26

Closed beattizzle closed 1 month ago

beattizzle commented 1 month ago

Removal of the GestureDetector with an empty onTap event allows for ancestor onTap events to fire instead of the inner class overriding the function call.

beattizzle commented 1 month ago

I attempted to write this unit test, but I couldn't get it to fail as I wanted to because I'd always have a CircularProgressIndicator instead of the GestureDetector(CustomPaint()). If someone has ideas on how to fix it, awesome, but it can otherwise be ignored.

simple_sheet_music_test.txt

tomoyu719 commented 1 month ago

Thank you for your contribution! We will temporarily remove the GestureDetector, but we plan to add a feature that triggers a callback when tapping on musical symbols. When we bring the GestureDetector back, we will ensure it accommodates the situation you pointed out. We appreciate your continued support!