Skip unretrievable Remote Images instead of exiting from probe failure

tomoyukikashiro / html2amp

html2amp is simple converter from HTML into AMP(Accelerated Mobile Pages).

MIT License

15 stars 15 forks source link

Skip unretrievable Remote Images instead of exiting from probe failure #166

Closed rpong closed 3 years ago

rpong commented 3 years ago

@tomoyukikashiro , we've been using the PR for some time, hoping this will get your approval. This little tweak skips the unavailable images during amp page generation from the original page, instead of exiting from Probe Failure.

rpong commented 3 years ago

@rpong Thank you for you contribution !! 🎉 I left some comments. plz check them and can you add tests for what you added ??

Thank you for these, i merged your suggestions. Will try to add tests for this change within the week.

rpong commented 3 years ago

@rpong Thank you for you contribution !! 🎉 I left some comments. plz check them and can you add tests for what you added ??

Unavailable images are ignored test added. Thank you @tomoyukikashiro