search

tompaana / intermediator-bot-sample

A sample bot, built with the Microsoft Bot Framework (v4), that routes messages between two users on different channels.
https://tompaana.github.io/content/chatbots_as_middlemen.html
MIT License
124 stars 66 forks source link

General tidy up, extracted some methods to clean switch readability, … #19

Closed garypretty closed 7 years ago

garypretty commented 7 years ago

…removed unnecessary usings and added missing method docs

daltskin commented 7 years ago

Nice - that was on my TODO list :)

garypretty commented 7 years ago

@daltskin :) also added a NoAgentsAvailable result so that if no agents are available then you can let the users know rather than allowing them to request and just sit there. Again, configurable via an app setting.

tompaana commented 7 years ago

Apparently you can't review merged PRs so here: Looks good, I approve :)

The thing about the indentation of the preprocessor directives (#pragma etc.) - is there a convention rule about them in C#? In any case we should keep them consistent.

garypretty commented 7 years ago

It's just a personal preference. I was also going to ask if you have a preference on use of the car keyword. I use it as standard and finding it hard to remember not to in order to remain in line with you

Sent from my Google Nexus 5X using FastHub

daltskin commented 7 years ago

You mean var?

Sent from a small telecommunications device.

From: Gary Pretty notifications@github.com Sent: Friday, August 18, 2017 9:19:49 AM To: tompaana/intermediator-bot-sample Cc: Jamie D; Mention Subject: Re: [tompaana/intermediator-bot-sample] General tidy up, extracted some methods to clean switch readability, … (#19)

It's just a personal preference. I was also going to ask if you have a preference on use of the car keyword. I use it as standard and finding it hard to remember not to in order to remain in line with you ??

Get Outlook for Androidhttps://aka.ms/ghei36

From: Tomi Paananen notifications@github.com Sent: Friday, August 18, 2017 9:14:52 AM To: tompaana/intermediator-bot-sample Cc: Gary Pretty; State change Subject: Re: [tompaana/intermediator-bot-sample] General tidy up, extracted some methods to clean switch readability, … (#19)

Apparently you can't review merged PRs so here: Looks good, I approve :)

The thing about the indentation of the preprocessor directives (#pragma etc.) - is there a convention rule about them in C#? In any case we should keep them consistent.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/tompaana/intermediator-bot-sample/pull/19#issuecomment-323290217, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADuE6ZklkAVWURKB5G1OjvmF-u6aHogHks5sZUf8gaJpZM4O7NIq.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/tompaana/intermediator-bot-sample/pull/19#issuecomment-323291473, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABmb7uRGkg3dCYDWI-YApBQzfdAPMKf4ks5sZUkkgaJpZM4O7NIq.

garypretty commented 7 years ago

Yes that's what I mean 😁

Sent from my Google Nexus 5X using FastHub

tompaana commented 7 years ago

I don't mind var here and there as long as one clearly understands the code. I always try to make "the code read like a book" and types are sometimes essential for the code to be self-documenting. I started with C/C++ so hence the love of types I guess.