search

tompaana / intermediator-bot-sample

A sample bot, built with the Microsoft Bot Framework (v4), that routes messages between two users on different channels.
https://tompaana.github.io/content/chatbots_as_middlemen.html
MIT License
124 stars 66 forks source link

Message routing fail if using Skype as Agent #24

Closed dzeping96 closed 6 years ago

dzeping96 commented 6 years ago

Sorry for my English first..

Skype: Customer Agent Bot Emulator: User

I found out that when I am using Skype as Agent, it unable to reply message to User, but I can receive message from User. If I am using other Channel other than Skype as Agent, it working fine. And also, I tried to use Bot Emulator as Agent and Skype as User, it is working fine too. I found out the problem is because of this part messageRouterResult = await messageRouterManager.HandleActivityAsync(activity, false);. If we using other Channel as Agent, it will reply OK as result, but if we using Skype as Agent, it will reply NoActionTaken as result. I just download this sample and tested without anything change, hope you can help me to solve this issues. Thanks a lot!

Here is some screenshot:- Agent on Skype image

User on Emulator image

tompaana commented 6 years ago

Thank you for reporting this and for the precise issue description! This is an obvious bug that needs to be fixed.

daltskin commented 6 years ago

Thought I'd fixed this a while back? https://github.com/tompaana/intermediator-bot-sample/commit/a19b34df7c0bfeedf6d0b4d357590b3c64bc8230

Get Outlook for iOShttps://aka.ms/o0ukef

From: Tomi Paananen notifications@github.com Sent: Sunday, November 19, 2017 9:54:25 AM To: tompaana/intermediator-bot-sample Cc: Subscribed Subject: Re: [tompaana/intermediator-bot-sample] Message routing fail if using Skype as Agent (#24)

Thank you for reporting this and for the precise issue description! This is an obvious bug that needs to be fixed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftompaana%2Fintermediator-bot-sample%2Fissues%2F24%23issuecomment-345504699&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca7cebc26333348da636d08d52f3384ef%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466820670771585&sdata=%2BmvxcnkXt48tupG0ibBXo5wcpx4hVtkZ%2F93%2Fs6wgx%2B8%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABmb7oxdjy0juae8v6sSR9g2c-oSq0Qoks5s3_rRgaJpZM4Qi20Y&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca7cebc26333348da636d08d52f3384ef%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466820670927862&sdata=Q6lBZOJTe9z8ifyPRBY0cJi%2Bsemt616Ge5SZ8WLss6I%3D&reserved=0.

tompaana commented 6 years ago

@daltskin Unfortunately that fix broke the functionality for many other channels. I didn't just revert the changes, but added a special case in the code for Skype, but must've missed to test the case where Skype is the agent channel.

daltskin commented 6 years ago

Hmm. Does highlight the challenge around channel testing. Labouriois without unit tests!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Tomi Paananen notifications@github.com Sent: Sunday, November 19, 2017 10:27:15 AM To: tompaana/intermediator-bot-sample Cc: Jamie D; Mention Subject: Re: [tompaana/intermediator-bot-sample] Message routing fail if using Skype as Agent (#24)

@daltskinhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdaltskin&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca9ed1d625fc24b2ee92b08d52f381c2a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466840384281452&sdata=QECdHZEf0%2Fs8G9MFx91C8qmHPDSp5ntDfZQJyldjvao%3D&reserved=0 Unfortunately that fix broke the functionality for many other channels. I didn't just revert the changes, but added a special case in the code for Skype, but must've missed to test the case where Skype is the agent channel.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftompaana%2Fintermediator-bot-sample%2Fissues%2F24%23issuecomment-345506447&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca9ed1d625fc24b2ee92b08d52f381c2a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466840384281452&sdata=3F2mXwp%2FBKjfj4ny0t0D8kQw9hO9avK4s%2F7LIsMLmVQ%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABmb7hrXGHn0AIIp34RErW9F73EsGDnFks5s4AKDgaJpZM4Qi20Y&data=02%7C01%7Cdaltskin%40hotmail.com%7Ca9ed1d625fc24b2ee92b08d52f381c2a%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636466840384281452&sdata=7gbAvhgT%2FBp3LXVV%2BavZSmn2DaYe0YG48O6MyMcMqMk%3D&reserved=0.

tompaana commented 6 years ago

@daltskin Indeed.

dzeping96 commented 6 years ago

@tompaana No problem. I will wait for your fix. Thank you so much!

dzeping96 commented 6 years ago

Hi @tompaana,

FYI, I found out another problem, which after I publish the sample to Azure App Service plan with Release configuration, the Skype channel won't reply anything at all, it still working fine on any other channel. Is this related with the bug I mentioned in this topic? Thanks!

daltskin commented 6 years ago

There are some conditional #debug statements, could be related...

Get Outlook for iOShttps://aka.ms/o0ukef

From: dzeping96 notifications@github.com Sent: Tuesday, November 21, 2017 7:14:15 AM To: tompaana/intermediator-bot-sample Cc: Jamie D; Mention Subject: Re: [tompaana/intermediator-bot-sample] Message routing fail if using Skype as Agent (#24)

Hi @tompaanahttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftompaana&data=02%7C01%7Cdaltskin%40hotmail.com%7Ce1807667f1db41bf173b08d530af7a27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636468452574309581&sdata=Qz%2B3DhRrp63CVf9vvN15xs72qRLk8O6ZJSVUwy5tWvA%3D&reserved=0,

FYI, I found out another problem, which after I publish the sample to Azure App Service plan with Release configuration, the Skype channel won't reply anything at all, it still working fine on any other channel. Is this related with the bug I mentioned in this topic? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftompaana%2Fintermediator-bot-sample%2Fissues%2F24%23issuecomment-345937440&data=02%7C01%7Cdaltskin%40hotmail.com%7Ce1807667f1db41bf173b08d530af7a27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636468452574309581&sdata=B%2Fdi%2BvaxCSbPrcU7CC8EafbeYf9cqnrOR0hC6HSEi1w%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABmb7mk047Aenemj6_rX2w7Wpqupnm45ks5s4nhHgaJpZM4Qi20Y&data=02%7C01%7Cdaltskin%40hotmail.com%7Ce1807667f1db41bf173b08d530af7a27%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636468452574309581&sdata=OegpXLW5%2BXIR3NU6p0VhT0zvLuF2hg45h7wM50oeoGw%3D&reserved=0.

dzeping96 commented 6 years ago

Hi @daltskin,

Thanks for your assisting, I just found out that Skype require some time to let the Channel online after switching endpoint. Thanks!

tompaana commented 6 years ago

Fixed in commit 49c7f08c10da4c6004ff4dad735ba18cc86972cd