search

tompave / fun_with_flags

Feature Flags/Toggles for Elixir
https://hexdocs.pm/fun_with_flags/FunWithFlags.html
MIT License
1.08k stars 79 forks source link

Add support for :binary_id Ecto primary key type #156

Closed whatyouhide closed 1 year ago

whatyouhide commented 1 year ago

My awesome coworker @vinniefranco made these changes a while ago: https://github.com/vinniefranco/fun_with_flags/commit/b432c4e1a108d6207be58106c7fcf446214736e3

I updated the README and thought maybe this could make it upstream, and eventually be released 🙃 We've been using this code in production for a good while now. The value could also be Ecto.UUID, for example.

whatyouhide commented 1 year ago

Btw, this is a revival of https://github.com/tompave/fun_with_flags/pull/129.

whatyouhide commented 1 year ago

@tompave hiya! Any chance you had some time to get some 👀 on this? 🙃

tylerbarker commented 1 year ago

Hey @whatyouhide , I've had a PR up here for quite some time so until @tompave returns I've created a Hex published fork. You're welcome to raise your pull request there and I'll check it out 🙂

whatyouhide commented 1 year ago

@tylerbarker thanks for reaching out, fork_with_flags looks good. I reached out to @tompave on a few platforms, let's see if they get back to me, otherwise yes, we'll consider switching to the fork 🙃

whatyouhide commented 1 year ago

@tompave I did all the stuff you mentioned 🙃, pushed just now.

tompave commented 1 year ago

Thank you @whatyouhide. I'll get this moving forward this week.

whatyouhide commented 1 year ago

@tompave okay sounds good. Let me know if I can help, so that we can get this over the finish line and get a release out if possible. Thanks! 🙏

tompave commented 1 year ago

It's merged. I want to so some manual tests in a host phoenix app before cutting a release. Just to better understand how UUID PKs behave with FWF, or if it needs some more documentation.

whatyouhide commented 1 year ago

@tompave sounds good! We're using FWF pretty heavily and have been using this change for a while if it helps. Let me know if I can help with the testing in any case.

tompave commented 1 year ago

Apologies for the wait. This has now been published on Hex: https://hex.pm/packages/fun_with_flags/1.11.0

whatyouhide commented 1 year ago

Thank you so much @tompave 🙏!