Open settermjd opened 7 years ago
Some responses
php-cs-fixer
is configured to sort the use statements and the sort-packages
config option makes composer keeps the json
file in order.Nice suggestion. The docker stuff is a work in progress, but as I said, I've been moving to cloud foundary (currently in a different branch) so a lot of it is obsolete.
The src
folder is separated by bounded contexts. Communication between them is through strict interfaces (probably a longer conversation to be had there). I've got some plans for further refactoring here.
I think your suggestions are good. The reason I've not got into it yet is because of the lack of decision here with regards to PSR-2
yet. Since everything is formatted by php-cs-fixer
, I'm waiting to see where this goes.
I completely agree, I just often miss the opportunity to add the extra detail as VIM doesn't flag them up. I will add additional annotations when I notice them ;)
Thanks for the feedback so far, it's really great to bounce ideas off another person - really appreciated!
Happy to help. Will try and keep helping out.
General Thoughts
Docker
This is just a personal preference, but what about moving the
docker-compose*
files in to a provisioning ordocker
directory? There's no specific need to. But might help to keep the repository that much tidier.Code
src
directory.Group use declaration
As you're using PHP7, what about using a group use declaration? For example, instead of
how about using:
IDE support
I know you're a VIM user though (I LOVE it for writing btw), but I'm a big PhpStorm user. And I know many who are. What are your thoughts on adding more IDE annotations to help with auto-completion? For example: