tompi / cheapino

An affordable split 36 keys keyboard
379 stars 14 forks source link

cheapino v2 build! partially working! some problems! #22

Closed jinchoung closed 3 months ago

jinchoung commented 3 months ago

hi!

so i ordered all the parts and the pcb for cheapino v2 and things mostly work!

the index finger columns and the pinky columns on both sides work. and the encoder works!

however, strangely, the middle finger and ring finger columns are completely dead. the weird thing is that they're completely dead on BOTH SIDES!

so that doesn't sound like i wired the switches incorrectly or there are bridges or anything.

any clue what this could be?

also, i've compiled my own QMK setup. but the keys are kind of crazy. the pinky row activates windows menus on the left hand and on the right hand, it brings up emoji stuff. and stuff like home row shift, ctrl, etc don't work even though they work on the default uf2. any thoughts?

thanks!

P.S. on the cheapino v1, it looks like the rp2040 microcontroller is attached on the left and right side and not the bottom edge. but the cheapino v2 had connectors for the bottom edge so i've soldered that on to. is that correct?

jinchoung commented 3 months ago

mine

oh well, here's the build... though it's still not fully functional, it looks and feels fantastic!

tompi commented 3 months ago

Hi, the build looks good.

I feel bad about this, because i uploaded an untested gerber(i thought I tested it, but turned out I was just workin on the previous prototype).

Anyway, there is a pretty straighforward fix, you need to run a bodge wire on both sides between the points in the picture: bodge

I think the best looking solution is to take off some keys and run the wire between switches on top plate, for both sides, this way it will be hidden, and wont attach to anything. If you prefer to do it on the back(easier) thats fine as well. I circled 2 pads and 2 holes on one side, just choose the most accessible, they are all connected directly.

This should take care of the missing keys!

Soldering the bottom of the rp2040 is fine. Im not using any of those pins, so its not needed. Im going to try to make a wireless version with the xiao seed studio, which only has pins on the sides...

For the software, I suspect you have an error in your setup. Could you try starting from scratch, following the firmware guide closely? Its quite new, please report anything strange!

tompi commented 3 months ago

Oh, and for the wire, anything should work, thinner is probably easier to solder. Twist, flux and tin the ends of the wire before soldering to the pcb will make it easy to work with.

jinchoung commented 3 months ago

hi thomas,

thank you much for responding.

THIS IS GREAT NEWS! lol. i was convinced i fried something on the rp2040 or did something else that would require me desoldering everything from everything and starting over! so this will take care of both columns (middle finger column and ring finger column) that are unresponsive on both boards right?

and a bodge wire is an easy peasy fix. WHEW.... really great news.

so i have my project for tomorrow.

and ok, will try to start over on the QMK thing too. everything in the instructions is current and proper for cheapino v2 yes? at least on the main page, things are still telling me to clone the cheapino (non v2) branch and i'm really confused about what exactly is required for v2.

thanks again!

jin

p.s. sorry, do you have a link to the firmware guide? i saw it somewhere once but it's not linked off of the main page. thanks.

p.s.2. does it make a difference that i just copied the uf2 file over onto the rp2040? do i have to do "make cheapino:default:flash" ?

tompi commented 3 months ago

Yeah, will fix both columns. The cheapino uses a special matrix that can double number of keys possible: https://kbd.news/The-Japanese-duplex-matrix-1391.html So one wire is used for 2 columns(but reversed diode direction for one)

Firmware guide is here: https://github.com/tompi/cheapino/blob/master/doc/firmware.md I just made one, and specified that you need to substitute "cheapino" with "cheapinov2". So you need to be careful in step 4 and 5

Flashing should be the same as copying uf2 file, so thats not the problem.

jinchoung commented 3 months ago

woohoo! soldered in the bodge wires on both sides and now everything is running smoooooooth! thanks much for all your help thomas! oh and the qmk programming was user error. i used lshft instead of lshft_t and that was causing the homerow modifiers to fire off constantly.

will post a few more photos when i get settled in.

thanks again.

jinchoung commented 3 months ago

let's see if this is how you close an issue....

jinchoung commented 3 months ago

20240312_213831 20240312_213848 20240312_213932 20240312_213946 20240312_213953

bodge wire totally fine on the underside!

aliexpress was shockingly reliable but the thing that they messed up on was the rubber feet. so in the meantime, i'm using a box of cards and some non slip shelf liner to try out a tenting setup. still feel pretty weird right now but i'm gettin' there.

all the home row modifiers are working well as well as the layer shifting overlayed on top of the functions on the thumb keys.

this was a fun little project. thanks thomas!

jinchoung commented 3 months ago

hi thomas,

so the keyboard is working amazingly well and i can't believe how smooth everything is. but i was wondering if you knew where i can edit the value to change the steps the encoder jumps per detent.

i looked over the qmk docs and they say to change the ENCODER_RESOLUTION value in config.h but there seems to be several different config.h files in the qmk_firmware folder. i made the change in the config.h in the cheapino folder but that didn't do it. also tried changing the ENCODER_RESOLUTION 4 value in encoder.c but that didn't do it either.

totally non-urgent.

thank you much and hope all is well in your world.

jin

On Tue, Mar 12, 2024 at 12:41 AM Thomas Haukland @.***> wrote:

Hi, the build looks good.

I feel bad about this, because i uploaded an untested gerber(i thought I tested it, but turned out I was just workin on the previous prototype).

Anyway, there is a pretty straighforward fix, you need to run a bodge wire on both sides between the points in the picture: bodge.png (view on web) https://github.com/tompi/cheapino/assets/231717/42632178-4c1d-4d74-8229-4d05b73d067e

I think the best looking solution is to take off some keys and run the wire between switches on top plate, for both sides, this way it will be hidden, and wont attach to anything. If you prefer to do it on the back(easier) thats fine as well. I circled 2 pads and 2 holes on one side, just choose the most accessible, they are all connected directly.

This should take care of the missing keys!

Soldering the bottom of the rp2040 is fine. Im not using any of those pins, so its not needed. Im going to try to make a wireless version with the xiao seed studio, which only has pins on the sides...

For the software, I suspect you have an error in your setup. Could you try starting from scratch, following the firmware guide closely? Its quite new, please report anything strange!

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-1990960480, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5DPAZ4ENDEDCGEJADBBXDYX2WTJAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJQHE3DANBYGA . You are receiving this because you authored the thread.Message ID: @.***>

tompi commented 3 months ago

Hey, great to hear!

Unfortunately, its not possible atm. I will try to code it up this weekend, shouldnt be much work i think. (i didnt even know about this value, but I see it defaults to 2, so I should fix this...)

søn. 17. mars 2024 kl. 02:18 skrev jinchoung @.***>:

hi thomas,

so the keyboard is working amazingly well and i can't believe how smooth everything is. but i was wondering if you knew where i can edit the value to change the steps the encoder jumps per detent.

i looked over the qmk docs and they say to change the ENCODER_RESOLUTION value in config.h but there seems to be several different config.h files in the qmk_firmware folder. i made the change in the config.h in the cheapino folder but that didn't do it. also tried changing the ENCODER_RESOLUTION 4 value in encoder.c but that didn't do it either.

totally non-urgent.

thank you much and hope all is well in your world.

jin

On Tue, Mar 12, 2024 at 12:41 AM Thomas Haukland @.***> wrote:

Hi, the build looks good.

I feel bad about this, because i uploaded an untested gerber(i thought I tested it, but turned out I was just workin on the previous prototype).

Anyway, there is a pretty straighforward fix, you need to run a bodge wire on both sides between the points in the picture: bodge.png (view on web) < https://github.com/tompi/cheapino/assets/231717/42632178-4c1d-4d74-8229-4d05b73d067e>

I think the best looking solution is to take off some keys and run the wire between switches on top plate, for both sides, this way it will be hidden, and wont attach to anything. If you prefer to do it on the back(easier) thats fine as well. I circled 2 pads and 2 holes on one side, just choose the most accessible, they are all connected directly.

This should take care of the missing keys!

Soldering the bottom of the rp2040 is fine. Im not using any of those pins, so its not needed. Im going to try to make a wireless version with the xiao seed studio, which only has pins on the sides...

For the software, I suspect you have an error in your setup. Could you try starting from scratch, following the firmware guide closely? Its quite new, please report anything strange!

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-1990960480, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5DPAZ4ENDEDCGEJADBBXDYX2WTJAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJQHE3DANBYGA>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2002227505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSJNTU56PSEQKJXAG553YYTVMVAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGIZDONJQGU . You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

jinchoung commented 3 months ago

oh wow, thanks for getting back to me.

oh cool, good to hear! please let me know when you get to it. of course, whenever you do get to it. no hurry.

thanks again!

jin

On Thu, Mar 21, 2024 at 12:10 AM Thomas Haukland @.***> wrote:

Hey, great to hear!

Unfortunately, its not possible atm. I will try to code it up this weekend, shouldnt be much work i think. (i didnt even know about this value, but I see it defaults to 2, so I should fix this...)

søn. 17. mars 2024 kl. 02:18 skrev jinchoung @.***>:

hi thomas,

so the keyboard is working amazingly well and i can't believe how smooth everything is. but i was wondering if you knew where i can edit the value to change the steps the encoder jumps per detent.

i looked over the qmk docs and they say to change the ENCODER_RESOLUTION value in config.h but there seems to be several different config.h files in the qmk_firmware folder. i made the change in the config.h in the cheapino folder but that didn't do it. also tried changing the ENCODER_RESOLUTION 4 value in encoder.c but that didn't do it either.

totally non-urgent.

thank you much and hope all is well in your world.

jin

On Tue, Mar 12, 2024 at 12:41 AM Thomas Haukland @.***> wrote:

Hi, the build looks good.

I feel bad about this, because i uploaded an untested gerber(i thought I tested it, but turned out I was just workin on the previous prototype).

Anyway, there is a pretty straighforward fix, you need to run a bodge wire on both sides between the points in the picture: bodge.png (view on web) <

https://github.com/tompi/cheapino/assets/231717/42632178-4c1d-4d74-8229-4d05b73d067e>

I think the best looking solution is to take off some keys and run the wire between switches on top plate, for both sides, this way it will be hidden, and wont attach to anything. If you prefer to do it on the back(easier) thats fine as well. I circled 2 pads and 2 holes on one side, just choose the most accessible, they are all connected directly.

This should take care of the missing keys!

Soldering the bottom of the rp2040 is fine. Im not using any of those pins, so its not needed. Im going to try to make a wireless version with the xiao seed studio, which only has pins on the sides...

For the software, I suspect you have an error in your setup. Could you try starting from scratch, following the firmware guide closely? Its quite new, please report anything strange!

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-1990960480,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5DPAZ4ENDEDCGEJADBBXDYX2WTJAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJQHE3DANBYGA>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2002227505, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABYSJNTU56PSEQKJXAG553YYTVMVAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGIZDONJQGU>

. You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2011350974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5DPA5O3A6V4CMMWWAY7FDYZKBUPAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGM2TAOJXGQ . You are receiving this because you modified the open/close state.Message ID: @.***>

tompi commented 3 months ago

Hey, updated my cheapino branch for qmk now.

You probably need to udate to latest qmk(1.1.5) for it to compile... Just save your own keymap, and do the steps from the firmware guide over again...

P.S. I tested a little and I kind of think ENCODER_RESOLUTION=1 works best. Change it in config.h

tor. 21. mars 2024 kl. 09:01 skrev jinchoung @.***>:

oh wow, thanks for getting back to me.

oh cool, good to hear! please let me know when you get to it. of course, whenever you do get to it. no hurry.

thanks again!

jin

On Thu, Mar 21, 2024 at 12:10 AM Thomas Haukland @.***> wrote:

Hey, great to hear!

Unfortunately, its not possible atm. I will try to code it up this weekend, shouldnt be much work i think. (i didnt even know about this value, but I see it defaults to 2, so I should fix this...)

søn. 17. mars 2024 kl. 02:18 skrev jinchoung @.***>:

hi thomas,

so the keyboard is working amazingly well and i can't believe how smooth everything is. but i was wondering if you knew where i can edit the value to change the steps the encoder jumps per detent.

i looked over the qmk docs and they say to change the ENCODER_RESOLUTION value in config.h but there seems to be several different config.h files in the qmk_firmware folder. i made the change in the config.h in the cheapino folder but that didn't do it. also tried changing the ENCODER_RESOLUTION 4 value in encoder.c but that didn't do it either.

totally non-urgent.

thank you much and hope all is well in your world.

jin

On Tue, Mar 12, 2024 at 12:41 AM Thomas Haukland @.***> wrote:

Hi, the build looks good.

I feel bad about this, because i uploaded an untested gerber(i thought I tested it, but turned out I was just workin on the previous prototype).

Anyway, there is a pretty straighforward fix, you need to run a bodge wire on both sides between the points in the picture: bodge.png (view on web) <

https://github.com/tompi/cheapino/assets/231717/42632178-4c1d-4d74-8229-4d05b73d067e>

I think the best looking solution is to take off some keys and run the wire between switches on top plate, for both sides, this way it will be hidden, and wont attach to anything. If you prefer to do it on the back(easier) thats fine as well. I circled 2 pads and 2 holes on one side, just choose the most accessible, they are all connected directly.

This should take care of the missing keys!

Soldering the bottom of the rp2040 is fine. Im not using any of those pins, so its not needed. Im going to try to make a wireless version with the xiao seed studio, which only has pins on the sides...

For the software, I suspect you have an error in your setup. Could you try starting from scratch, following the firmware guide closely? Its quite new, please report anything strange!

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-1990960480,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5DPAZ4ENDEDCGEJADBBXDYX2WTJAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJQHE3DANBYGA>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2002227505,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AABYSJNTU56PSEQKJXAG553YYTVMVAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGIZDONJQGU>

. You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2011350974, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5DPA5O3A6V4CMMWWAY7FDYZKBUPAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGM2TAOJXGQ>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2011486261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSJLNGDSALUHF4DI3AW3YZKHV5AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGQ4DMMRWGE . You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

jinchoung commented 3 months ago

hi thomas,

oh wow, fantastic! that was fast! thank you so much!

ok, will update qmk_msys and will try a new compile. can't wait to give this a try.

thanks again and hope you have a great weekend.

jin

On Sat, Mar 23, 2024 at 2:25 PM Thomas Haukland @.***> wrote:

Hey, updated my cheapino branch for qmk now.

You probably need to udate to latest qmk(1.1.5) for it to compile... Just save your own keymap, and do the steps from the firmware guide over again...

P.S. I tested a little and I kind of think ENCODER_RESOLUTION=1 works best. Change it in config.h

tor. 21. mars 2024 kl. 09:01 skrev jinchoung @.***>:

oh wow, thanks for getting back to me.

oh cool, good to hear! please let me know when you get to it. of course, whenever you do get to it. no hurry.

thanks again!

jin

On Thu, Mar 21, 2024 at 12:10 AM Thomas Haukland @.***> wrote:

Hey, great to hear!

Unfortunately, its not possible atm. I will try to code it up this weekend, shouldnt be much work i think. (i didnt even know about this value, but I see it defaults to 2, so I should fix this...)

søn. 17. mars 2024 kl. 02:18 skrev jinchoung @.***>:

hi thomas,

so the keyboard is working amazingly well and i can't believe how smooth everything is. but i was wondering if you knew where i can edit the value to change the steps the encoder jumps per detent.

i looked over the qmk docs and they say to change the ENCODER_RESOLUTION value in config.h but there seems to be several different config.h files in the qmk_firmware folder. i made the change in the config.h in the cheapino folder but that didn't do it. also tried changing the ENCODER_RESOLUTION 4 value in encoder.c but that didn't do it either.

totally non-urgent.

thank you much and hope all is well in your world.

jin

On Tue, Mar 12, 2024 at 12:41 AM Thomas Haukland @.***> wrote:

Hi, the build looks good.

I feel bad about this, because i uploaded an untested gerber(i thought I tested it, but turned out I was just workin on the previous prototype).

Anyway, there is a pretty straighforward fix, you need to run a bodge wire on both sides between the points in the picture: bodge.png (view on web) <

https://github.com/tompi/cheapino/assets/231717/42632178-4c1d-4d74-8229-4d05b73d067e>

I think the best looking solution is to take off some keys and run the wire between switches on top plate, for both sides, this way it will be hidden, and wont attach to anything. If you prefer to do it on the back(easier) thats fine as well. I circled 2 pads and 2 holes on one side, just choose the most accessible, they are all connected directly.

This should take care of the missing keys!

Soldering the bottom of the rp2040 is fine. Im not using any of those pins, so its not needed. Im going to try to make a wireless version with the xiao seed studio, which only has pins on the sides...

For the software, I suspect you have an error in your setup. Could you try starting from scratch, following the firmware guide closely? Its quite new, please report anything strange!

— Reply to this email directly, view it on GitHub < https://github.com/tompi/cheapino/issues/22#issuecomment-1990960480>,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5DPAZ4ENDEDCGEJADBBXDYX2WTJAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJQHE3DANBYGA>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2002227505,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AABYSJNTU56PSEQKJXAG553YYTVMVAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGIZDONJQGU>

. You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2011350974,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5DPA5O3A6V4CMMWWAY7FDYZKBUPAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGM2TAOJXGQ>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2011486261, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABYSJLNGDSALUHF4DI3AW3YZKHV5AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGQ4DMMRWGE>

. You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2016606750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5DPAZGHIQKKR7JADCH4LLYZXXM5AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGYYDMNZVGA . You are receiving this because you modified the open/close state.Message ID: @.***>

jinchoung commented 3 months ago

hi thomas,

ok, newb question. where is the correct config.h to modify?

is it the one in C:\Users\jinch_000\qmk_firmware\keyboards\cheapino ?

i had a look at that and it doesn't have any entries on the encoder. if that's the right one, do i just add:

ENCODER_RESOLUTION=1

thanks again.

jin

On Sat, Mar 23, 2024 at 2:25 PM Thomas Haukland @.***> wrote:

Hey, updated my cheapino branch for qmk now.

You probably need to udate to latest qmk(1.1.5) for it to compile... Just save your own keymap, and do the steps from the firmware guide over again...

P.S. I tested a little and I kind of think ENCODER_RESOLUTION=1 works best. Change it in config.h

tor. 21. mars 2024 kl. 09:01 skrev jinchoung @.***>:

oh wow, thanks for getting back to me.

oh cool, good to hear! please let me know when you get to it. of course, whenever you do get to it. no hurry.

thanks again!

jin

On Thu, Mar 21, 2024 at 12:10 AM Thomas Haukland @.***> wrote:

Hey, great to hear!

Unfortunately, its not possible atm. I will try to code it up this weekend, shouldnt be much work i think. (i didnt even know about this value, but I see it defaults to 2, so I should fix this...)

søn. 17. mars 2024 kl. 02:18 skrev jinchoung @.***>:

hi thomas,

so the keyboard is working amazingly well and i can't believe how smooth everything is. but i was wondering if you knew where i can edit the value to change the steps the encoder jumps per detent.

i looked over the qmk docs and they say to change the ENCODER_RESOLUTION value in config.h but there seems to be several different config.h files in the qmk_firmware folder. i made the change in the config.h in the cheapino folder but that didn't do it. also tried changing the ENCODER_RESOLUTION 4 value in encoder.c but that didn't do it either.

totally non-urgent.

thank you much and hope all is well in your world.

jin

On Tue, Mar 12, 2024 at 12:41 AM Thomas Haukland @.***> wrote:

Hi, the build looks good.

I feel bad about this, because i uploaded an untested gerber(i thought I tested it, but turned out I was just workin on the previous prototype).

Anyway, there is a pretty straighforward fix, you need to run a bodge wire on both sides between the points in the picture: bodge.png (view on web) <

https://github.com/tompi/cheapino/assets/231717/42632178-4c1d-4d74-8229-4d05b73d067e>

I think the best looking solution is to take off some keys and run the wire between switches on top plate, for both sides, this way it will be hidden, and wont attach to anything. If you prefer to do it on the back(easier) thats fine as well. I circled 2 pads and 2 holes on one side, just choose the most accessible, they are all connected directly.

This should take care of the missing keys!

Soldering the bottom of the rp2040 is fine. Im not using any of those pins, so its not needed. Im going to try to make a wireless version with the xiao seed studio, which only has pins on the sides...

For the software, I suspect you have an error in your setup. Could you try starting from scratch, following the firmware guide closely? Its quite new, please report anything strange!

— Reply to this email directly, view it on GitHub < https://github.com/tompi/cheapino/issues/22#issuecomment-1990960480>,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5DPAZ4ENDEDCGEJADBBXDYX2WTJAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJQHE3DANBYGA>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2002227505,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AABYSJNTU56PSEQKJXAG553YYTVMVAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGIZDONJQGU>

. You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2011350974,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5DPA5O3A6V4CMMWWAY7FDYZKBUPAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGM2TAOJXGQ>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2011486261, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABYSJLNGDSALUHF4DI3AW3YZKHV5AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGQ4DMMRWGE>

. You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2016606750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5DPAZGHIQKKR7JADCH4LLYZXXM5AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWGYYDMNZVGA . You are receiving this because you modified the open/close state.Message ID: @.***>

jinchoung commented 3 months ago

hi thomas,

okay, so doing some research on my own, i found some things out (maybe) but ran into issues:

so is it correct that i'm editing the config.h file here - C:\Users\jinch_000\qmk_firmware\keyboards\cheapino ?

and is the correct syntax - #define ENCODER_RESOLUTION 1 ?


so after that, i tried compiling again with - qmk flash -kb cheapino -km jin10

but this time, i ran into compile errors. i tried removing my addition with the encoder resolution definition and still came up with errors even before it got to the config.h .... here is what it says:

arm-none-eabi-gcc.exe (GCC) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiling: keyboards/cheapino/encoder.c
                [OK]
Compiling: keyboards/cheapino/matrix.c
                [OK]
Compiling: keyboards/cheapino/cheapino.c
                [OK]
Compiling: .build/obj_cheapino_jin10/src/default_keyboard.c
                [OK]
Compiling: quantum/keymap_introspection.c
               In file included from quantum/keymap_introspection.c:5:
./.build/obj_cheapino_jin10/src/keymap.c:17:34: error: macro "LAYOUT_split_3x5_3" requires 36 arguments, but only 1 given
   17 |         [5] = LAYOUT_split_3x5_3(),
      |                                  ^
In file included from ./.build/obj_cheapino_jin10/src/keymap.c:1:
./.build/obj_cheapino_jin10/src/default_keyboard.h:31: note: macro "LAYOUT_split_3x5_3" defined here
   31 | #define LAYOUT_split_3x5_3(k4K, k4J, k4I, k4H, k4G, k0A, k0B, k0C, k0D, k0E, k5K, k5J, k5I, k5H, k5G, k1A, k1B, k1C, k1D, k1E, k6K, k6J, k6I, k6H, k6G, k2A, k2B, k2C, k2D, k2E, k6L, k5L, k4L, k0F, k1F, k2F) { \
      |
./.build/obj_cheapino_jin10/src/keymap.c:17:15: error: 'LAYOUT_split_3x5_3' undeclared here (not in a function)
   17 |         [5] = LAYOUT_split_3x5_3(),
      |               ^~~~~~~~~~~~~~~~~~
 [ERRORS]

and this is after i updated qmk and redid the steps from your qmk guide. (i don't know if it matters but i made an error this time around where i accidentally typed git fetch tompi cheapino instead of git fetch tompi cheapinov2 but i typed in the v2 command afterward. did that mess anything up?

my prep to compiling:

# Update the package database and core system packages with:
pacman -Syu  

git fetch tompi cheapinov2
git checkout tompi/cheapinov2
qmk flash -kb cheapino -km jin10

thanks!

jin

tompi commented 3 months ago

This sounds like you might have an error in your keymap?

Does it compile with -km tompi ?

Send me your keymap if you like, and i can have a look

@.***, 90786985

On Mon, 25 Mar 2024 at 01:30, jinchoung @.***> wrote:

hi thomas,

okay, so doing some research on my own, i found some things out (maybe) but ran into issues:

so is it correct that i'm editing the config.h file here - C:\Users\jinch_000\qmk_firmware\keyboards\cheapino ?

and is the correct syntax - #define ENCODER_RESOLUTION 1 ?

so after that, i tried compiling again with - qmk flash -kb cheapino -km jin10

but this time, i ran into compile errors. i tried removing my addition with the encoder resolution definition and still came up with errors even before it got to the config.h .... here is what it says:

`arm-none-eabi-gcc.exe (GCC) 12.2.0 Copyright (C) 2022 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiling: keyboards/cheapino/encoder.c [OK] Compiling: keyboards/cheapino/matrix.c [OK] Compiling: keyboards/cheapino/cheapino.c [OK] Compiling: .build/obj_cheapino_jin10/src/default_keyboard.c [OK] Compiling: quantum/keymap_introspection.c In file included from quantum/keymap_introspection.c:5: ./.build/obj_cheapino_jin10/src/keymap.c:17:34: error: macro "LAYOUT_split_3x5_3" requires 36 arguments, but only 1 given 17 [5] = LAYOUT_split_3x5_3(), ^ In file included from ./.build/obj_cheapino_jin10/src/keymap.c:1: ./.build/obj_cheapino_jin10/src/default_keyboard.h:31: note: macro "LAYOUT_split_3x5_3" defined here 31 #define LAYOUT_split_3x5_3(k4K, k4J, k4I, k4H, k4G, k0A, k0B, k0C, k0D, k0E, k5K, k5J, k5I, k5H, k5G, k1A, k1B, k1C, k1D, k1E, k6K, k6J, k6I, k6H, k6G, k2A, k2B, k2C, k2D, k2E, k6L, k5L, k4L, k0F, k1F, k2F) {

./.build/obj_cheapino_jin10/src/keymap.c:17:15: error: 'LAYOUT_split_3x5_3' undeclared here (not in a function) 17 | [5] = LAYOUT_split_3x5_3(), | ^~~~~~ [ERRORS]`

and this is after i updated qmk and redid the steps from your qmk guide.

any insight?

thanks!

jin

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017014120, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSJI35AFNUFXWY2CXB33YZ5VZVAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGAYTIMJSGA . You are receiving this because you commented.Message ID: @.***>

jinchoung commented 3 months ago

oh wow. yes it did compile. ok, so i changed my keymap since the last time and i guess it didn't like those changes.

huh... the only difference was that i added a "gaming layer" on layer 6...

EDIT: edit, ah, i think i found the problem to my gaming layer... so i added a toggle-able layer on layer 6 but i had a blank layer 5 and i think the firmware doesn't like that i skipped. so i just added a couple of buttons to layer 5 so that it's not blank and it worked like a charm.

hmmm... but encoder is still not taking any values i put in....


am i correct about the encoder?

that i'm editing the config.h file here - C:\Users\jinch_000\qmk_firmware\keyboards\cheapino ?

and is the correct syntax - #define ENCODER_RESOLUTION 1 ?

i've tried playing with this setting but no matter what i enter here, nothing seems to change.

or... it's still jumping so many lines that i can't tell if it's working... assuming i'm correct about where i'm adding the the line, is there a value i can put in that would be the equivalent of just scrolling one line at a time? just so i can see if it's doing anything?

thank you much!

jin

tompi commented 3 months ago

Yep, try setting it to 2, and you should need to use 2 «ticks» per triggered «action»

@.***, 90786985

On Mon, 25 Mar 2024 at 07:04, jinchoung @.***> wrote:

oh wow. yes it did compile. ok, so i changed my keymap since the last time and i guess it didn't like those changes.

huh... the only difference was that i added a "gaming layer" on layer 6 without any of the home row modifiers and i was using TO 6 to jump to layer 6 and then from layer 6, TO 0 to go back to the default layer. that must be the wrong way to do that then... ok. i can play around with that.

oh, but am i correct about the encoder?

that i'm editing the config.h file here - C:\Users\jinch_000\qmk_firmware\keyboards\cheapino ?

and is the correct syntax - #define ENCODER_RESOLUTION 1 ?

thank you much!

jin

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017289288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSJIHHVTCRHFCVFB643TYZ6455AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGI4DSMRYHA . You are receiving this because you commented.Message ID: @.***>

jinchoung commented 3 months ago

oh interesting... so it's determining how many clicks before a command is issued? huh.

my issue with the encoder is that every command that is issued jumps too much... it seems to jump down almost a screen at a time and for me, that's more disorienting than it is helpful.

so what i wanted to do was, if right now, it's jumping ten lines at a time, i wanted to try reducing that, maybe even to just one line at a time. more like how the mouse scroll wheel works.

is there a setting i can adjust for that?

thanks.

jin

On Mon, Mar 25, 2024 at 2:44 AM Thomas Haukland @.***> wrote:

Yep, try setting it to 2, and you should need to use 2 «ticks» per triggered «action»

@.***, 90786985

On Mon, 25 Mar 2024 at 07:04, jinchoung @.***> wrote:

oh wow. yes it did compile. ok, so i changed my keymap since the last time and i guess it didn't like those changes.

huh... the only difference was that i added a "gaming layer" on layer 6 without any of the home row modifiers and i was using TO 6 to jump to layer 6 and then from layer 6, TO 0 to go back to the default layer. that must be the wrong way to do that then... ok. i can play around with that.

oh, but am i correct about the encoder?

that i'm editing the config.h file here - C:\Users\jinch_000\qmk_firmware\keyboards\cheapino ?

and is the correct syntax - #define ENCODER_RESOLUTION 1 ?

thank you much!

jin

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017289288, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABYSJIHHVTCRHFCVFB643TYZ6455AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGI4DSMRYHA>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017595572, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5DPA6IUI4TX3BKRCHJH6DYZ7WXBAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGU4TKNJXGI . You are receiving this because you modified the open/close state.Message ID: @.***>

tompi commented 3 months ago

OK, i see, Im guessing you mapped encoder to mouse movement keys like scroll wheel up/down?

If so, you probably need to adjust these: https://docs.qmk.fm/#/feature_mouse_keys?id=accelerated-mode

man. 25. mars 2024 kl. 13:17 skrev jinchoung @.***>:

oh interesting... so it's determining how many clicks before a command is issued? huh.

my issue with the encoder is that every command that is issued jumps too much... it seems to jump down almost a screen at a time and for me, that's more disorienting than it is helpful.

so what i wanted to do was, if right now, it's jumping ten lines at a time, i wanted to try reducing that, maybe even to just one line at a time. more like how the mouse scroll wheel works.

is there a setting i can adjust for that?

thanks.

jin

On Mon, Mar 25, 2024 at 2:44 AM Thomas Haukland @.***> wrote:

Yep, try setting it to 2, and you should need to use 2 «ticks» per triggered «action»

@.***, 90786985

On Mon, 25 Mar 2024 at 07:04, jinchoung @.***> wrote:

oh wow. yes it did compile. ok, so i changed my keymap since the last time and i guess it didn't like those changes.

huh... the only difference was that i added a "gaming layer" on layer 6 without any of the home row modifiers and i was using TO 6 to jump to layer 6 and then from layer 6, TO 0 to go back to the default layer. that must be the wrong way to do that then... ok. i can play around with that.

oh, but am i correct about the encoder?

that i'm editing the config.h file here - C:\Users\jinch_000\qmk_firmware\keyboards\cheapino ?

and is the correct syntax - #define ENCODER_RESOLUTION 1 ?

thank you much!

jin

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017289288,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AABYSJIHHVTCRHFCVFB643TYZ6455AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGI4DSMRYHA>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017595572, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AA5DPA6IUI4TX3BKRCHJH6DYZ7WXBAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGU4TKNJXGI>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017874495, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSJMVMCV5EFLIMBHXZGDY2AIWHAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXHA3TINBZGU . You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

jinchoung commented 3 months ago

actually, i didn't map the encoder at all. it was just in this state as a default.

i didn't even know it was programmable. cool. so i've been using the online qmk configurator for programming the keys. can i do encoder like that as well?

or if it's a file, what file currently contains the encoder configuration that i have now?

thanks again.

jin

On Mon, Mar 25, 2024 at 6:15 AM Thomas Haukland @.***> wrote:

OK, i see, Im guessing you mapped encoder to mouse movement keys like scroll wheel up/down?

If so, you probably need to adjust these: https://docs.qmk.fm/#/feature_mouse_keys?id=accelerated-mode

man. 25. mars 2024 kl. 13:17 skrev jinchoung @.***>:

oh interesting... so it's determining how many clicks before a command is issued? huh.

my issue with the encoder is that every command that is issued jumps too much... it seems to jump down almost a screen at a time and for me, that's more disorienting than it is helpful.

so what i wanted to do was, if right now, it's jumping ten lines at a time, i wanted to try reducing that, maybe even to just one line at a time. more like how the mouse scroll wheel works.

is there a setting i can adjust for that?

thanks.

jin

On Mon, Mar 25, 2024 at 2:44 AM Thomas Haukland @.***> wrote:

Yep, try setting it to 2, and you should need to use 2 «ticks» per triggered «action»

@.***, 90786985

On Mon, 25 Mar 2024 at 07:04, jinchoung @.***> wrote:

oh wow. yes it did compile. ok, so i changed my keymap since the last time and i guess it didn't like those changes.

huh... the only difference was that i added a "gaming layer" on layer 6 without any of the home row modifiers and i was using TO 6 to jump to layer 6 and then from layer 6, TO 0 to go back to the default layer. that must be the wrong way to do that then... ok. i can play around with that.

oh, but am i correct about the encoder?

that i'm editing the config.h file here - C:\Users\jinch_000\qmk_firmware\keyboards\cheapino ?

and is the correct syntax - #define ENCODER_RESOLUTION 1 ?

thank you much!

jin

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017289288,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AABYSJIHHVTCRHFCVFB643TYZ6455AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGI4DSMRYHA>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017595572,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AA5DPA6IUI4TX3BKRCHJH6DYZ7WXBAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXGU4TKNJXGI>

. You are receiving this because you modified the open/close state.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017874495, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABYSJMVMCV5EFLIMBHXZGDY2AIWHAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXHA3TINBZGU>

. You are receiving this because you commented.Message ID: @.***>

-- @.***, 90786985

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2017985062, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5DPA7NZBD7VE54657Y3ALY2APN5AVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJXHE4DKMBWGI . You are receiving this because you modified the open/close state.Message ID: @.***>

jinchoung commented 3 months ago

oh... hang on... is it:

C:\Users\jinch_000\qmk_firmware\keyboards\cheapino\encoder.c ?

according to that, on the home layer, the command a click is set for is KC_PGDN and KC_PGUP ... which would indeed cause the screen to jump in large increments.

ok, will test this out but if this is where the configuration for the encoder lives, i think i can figure out how to make a go of this.

thanks again.

jin

jinchoung commented 3 months ago

woohoo...

that's the file. i have it all configured now juuuuuuussssssssst how i like it with the encoder doing mouse wheel up and down on the base layer and pgup and pgdown as you had it in layer1 as well as volume controls on layers 5 and 6.

one thing i'd recommend is adding the config.h and encoder.c locations and instructions about encoder functionality in the docs. qmk configurator worked great for me for the keyboard but it doesn't deal with the encoder at all and i had no idea what the default settings even were or how to change it and unfortunately, googling for that precise issue ends up sending you all over the place and would be difficult for a newb to get the required information.

thanks again for the awesome project and helping me to get to this point! as i said before, this keyboard just feels sooooooo luxurious and 'right' and i'm really loving it!

jin

tompi commented 3 months ago

Sorry for the late reply, but you figured it out yourself i see!

You are right, i will add this to the fw guide. Its not self explanatory.

Happy easter!

@.***, 90786985

On Tue, 26 Mar 2024 at 04:56, jinchoung @.***> wrote:

woohoo...

that's the file. i have it all configured now juuuuuuussssssssst how i like it with the encoder doing mouse wheel up and down on the base layer and pgup and pgdown as you had it in layer1 as well as volume controls on layers 5 and 6.

one thing i'd recommend is adding the config.h and encoder.c locations and instructions about encoder functionality in the docs. qmk configurator worked great for me for the keyboard but it doesn't deal with the encoder at all and i had no idea what the default settings even were or how to change it and unfortunately, googling for that precise issue ends up sending you all over the place and would be difficult for a newb to get the required information.

thanks again for the awesome project and helping me to get to this point! as i said before, this keyboard just feels sooooooo luxurious and 'right' and i'm really loving it!

jin

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2019336966, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYSJMKXVBQNXSOJQBL5DLY2DWYVAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJZGMZTMOJWGY . You are receiving this because you commented.Message ID: @.***>

jinchoung commented 3 months ago

hey thomas,

no problem. thanks for all your help in getting me to the promised land. : ) nothing but smooth typing ahead!

happy easter!

jin

On Tue, Mar 26, 2024 at 10:18 PM Thomas Haukland @.***> wrote:

Sorry for the late reply, but you figured it out yourself i see!

You are right, i will add this to the fw guide. Its not self explanatory.

Happy easter!

@.***, 90786985

On Tue, 26 Mar 2024 at 04:56, jinchoung @.***> wrote:

woohoo...

that's the file. i have it all configured now juuuuuuussssssssst how i like it with the encoder doing mouse wheel up and down on the base layer and pgup and pgdown as you had it in layer1 as well as volume controls on layers 5 and 6.

one thing i'd recommend is adding the config.h and encoder.c locations and instructions about encoder functionality in the docs. qmk configurator worked great for me for the keyboard but it doesn't deal with the encoder at all and i had no idea what the default settings even were or how to change it and unfortunately, googling for that precise issue ends up sending you all over the place and would be difficult for a newb to get the required information.

thanks again for the awesome project and helping me to get to this point! as i said before, this keyboard just feels sooooooo luxurious and 'right' and i'm really loving it!

jin

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2019336966, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABYSJMKXVBQNXSOJQBL5DLY2DWYVAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJZGMZTMOJWGY>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/tompi/cheapino/issues/22#issuecomment-2021958071, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA5DPA2UEELUVZ4DLN6F3ULY2JJCZAVCNFSM6AAAAABERGV4KWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRRHE2TQMBXGE . You are receiving this because you modified the open/close state.Message ID: @.***>