search

tomplus / kubernetes_asyncio

Python asynchronous client library for Kubernetes http://kubernetes.io/
Apache License 2.0
364 stars 71 forks source link

Fix usage of `response_types_map` inside API client's `call_api` method. #311

Open ndhansen opened 6 months ago

ndhansen commented 6 months ago

Fixes https://github.com/tomplus/kubernetes_asyncio/issues/310

I didn't add tests because I couldn't see any existing tests for the call_api method, but if I missed it, please let me know.

I accidentally didn't read the contribution guidelines before creating this, I'll leave this in draft until the issue has been validated / accepted.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 28.70%. Comparing base (c2c8933) to head (7d5a549).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #311 +/- ## ======================================= Coverage 28.70% 28.70% ======================================= Files 725 725 Lines 86624 86626 +2 ======================================= + Hits 24864 24866 +2 Misses 61760 61760 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tomplus commented 6 months ago

LGTM, but i can't merge it as is a "draft".