search

tompollard / sammon

Sammon mapping in Python
32 stars 18 forks source link

Test is not working #2

Closed Irene-GM closed 7 years ago

Irene-GM commented 9 years ago

Hi Tom,

Thanks for your code. I had similar problems as in the Issue #1 (https://github.com/tompollard/sammon/issues/1) and applying the suggestions to the code, it is working and providing the following image, which might be nice to add to the main page of the project. :-) iris

What I can do now is making a pull request.

Irene-GM commented 9 years ago

Hey, I tried to create a pull request (first time, sorry), but I have no idea if you got it. I see your Sammon repository copied in my workspace, but with the modified file instead of the original. However, I have no idea if I have to do extra steps...

tompollard commented 9 years ago

Hey Irene,

Many thanks for looking at this. It looks like you made the pull request on your own forked repository, rather than my upstream one. You can make a new request using the button at: https://github.com/tompollard/sammon/pulls. Nice idea to include the figure :) Please could you contribute this with a pull request too?

Tom

Irene-GM commented 9 years ago

Hi Tom!

Thanks for your quick response. Please, check if I did correctly the pull request. I am totally new to this operation. Thanks!

tompollard commented 9 years ago

Great, thanks Irene, I got the pull request :) Will test and merge the request as soon as I get the chance!

tompollard commented 7 years ago

Thanks again @Irene-GM