search

tomquirk / linkedin-api

👨‍💼Linkedin API for Python
MIT License
1.71k stars 401 forks source link

fixing jobs api connection #336

Closed Njoselson closed 9 months ago

Njoselson commented 10 months ago

This is a continuation of the API fixes as a result of linkedin updating their Voyager API. Specifically this addresses #335 which was also talked about in PR #332 especially the comment here.

This also adds some more testing of the filters than what was there before.

Njoselson commented 10 months ago

Note, there are still a lot of broken API's, but this at least fixes the search_jobs endpoints, which were asked for by a lot of people.

Njoselson commented 10 months ago

@ignaciovi Can you take a look and see whether this is a better way of formatting the query strings than the long f-strings in the other PR?

gustavo-momente commented 9 months ago

It seems that it enters an infinite loop if there are no returned results

Njoselson commented 9 months ago

Haha! Good catch! I will fix! 😅

Njoselson commented 9 months ago

what do you think now @gustavo-momente ?

tomquirk commented 9 months ago

@Njoselson thanks for this PR! Appreciate the initiative. Do you think it's a net improvement on what we have now? If yes, let's merge and consider improvements/optimizations in a follow-up PR if necessary 🚀

Njoselson commented 9 months ago

Hey! Yeah, unfortunately this is also part of the API that is now broken due to updates to the voyager service.

So this is an improvement in that it now passes tests that used to be broken.

tomquirk commented 9 months ago

@Njoselson awesome! Thanks again, let's merge 🏁