search

tomquirk / linkedin-api

👨‍💼Linkedin API for Python
MIT License
1.71k stars 401 forks source link

Search Endpoints Don't Pass Tests #341

Closed Njoselson closed 3 months ago

Njoselson commented 9 months ago

Hi, I am still trying to figure out what we need to do to release a new version of this package (maybe version 2.1.0?) and running tests locally I see that despite having merged #332 We still have the following test failures:

FAILED tests/test_linkedin_api_requests.py::test_search - assert []
FAILED tests/test_linkedin_api_requests.py::test_search_pagination - KeyError: 'type'
FAILED tests/test_linkedin_api_requests.py::test_search_with_limit - AssertionError: assert 13 == 1
FAILED tests/test_linkedin_api_requests.py::test_search_people_with_limit - AssertionError: assert...
FAILED tests/test_linkedin_api_requests.py::test_search_people_by_region - requests.exceptions.Con...

I know based on this that we can't set up automated CI/CD for the repo because of challenges, but I still think that even if the functionality is mostly fixed, we should still try to have all relevant tests pass for this search function.