feature(Refactor and adding support for future release):

tomquirk / linkedin-api

👨‍💼 LinkedIn API for Python

https://pypi.org/project/linkedin-api

MIT License

1.94k stars 430 forks source link

feature(Refactor and adding support for future release): #408

Open PipesNBottles opened 2 months ago

PipesNBottles commented 2 months ago

adds query options to make it easier to distinguish what can be searched for
adds abstract class for inheritance later on for linkedin class
moves imports around for errors and settings
changes from pipfile to poetry for development
adds api builder class to isolate the api and param passing
adds schemas for responses from linkedin allowing objects and type checking in the future
adds future libraries for 3.8 release

tomquirk commented 2 months ago

Hey @PipesNBottles , thank you for this! Will take me a bit to review this one. Hopefully I can get to it soon 🙏

PipesNBottles commented 2 months ago

Hey @PipesNBottles , thank you for this! Will take me a bit to review this one. Hopefully I can get to it soon 🙏

Not a problem, take your time. If you find any issues I'll respond here

tomquirk commented 1 month ago

Hey @PipesNBottles , just a quick one to say that I haven't forgotten about this! I think we'll want to pull some of your ideas into master in a piece-meal fashion. I'll probably pick out various parts of this and merge separately (and add you as commit co-author for attribution, of course).

tomquirk commented 3 weeks ago

Poetry migration is in 🫡 https://github.com/tomquirk/linkedin-api/pull/423