search

tomroh / leaflegend

Provides extensions to the leaflet R package to customize legends with images, text styling, orientation, sizing, and symbology.
https://leaflegend.delveds.com
Other
34 stars 3 forks source link

Leaflet Group Support #26

Closed radbasa closed 3 years ago

radbasa commented 3 years ago

Reference Issue #25

radbasa commented 3 years ago

I'll have to try this again. Sorry. Still learning how to make R packages.

tomroh commented 3 years ago

@radbasa when I review the code changes, it shows the entire file as deleted and then the code old & new as an addition. This is likely due to the line endings issue. Can you re-base your branch and then add your edits so that the diff shows the changes correctly?

radbasa commented 3 years ago

@radbasa when I review the code changes, it shows the entire file as deleted and then the code old & new as an addition. This is likely due to the line endings issue. Can you re-base your branch and then add your edits so that the diff shows the changes correctly?

Yeah, it was a line endings issue. LF vs CRLF. I tried to fix it in place. It was too much trouble. Since my edits was a manageable number of lines, I have decided to withdraw this pull request. I created a new branch with my edits, made sure the CRLF EOLs were retained.

Please see Pull Request #27.