search

tomroh / leaflegend

Provides extensions to the leaflet R package to customize legends with images, text styling, orientation, sizing, and symbology.
https://leaflegend.delveds.com
Other
34 stars 3 forks source link

Fix tests to prepare for upcoming leaflet v2.2.0 release #70

Closed gadenbuie closed 1 year ago

gadenbuie commented 1 year ago

Hi @tomroh! We're preparing the next release of leaflet (v2.2.0, rstudio/leaflet#876) and noticed that our updates break a test in your package.

I've provided a relatively simple fix in this PR. In essence, leaflet() now includes its own dependencies in the dependencies item of the returned htmlwidgets object, which means that it contains both our dependencies and the dependencies your extension has added. I simply switch from testthat::expect_equal() to testthat::expect_contains().

Do you think you'd be able to update your package on CRAN in the next two weeks? We're planning on submitting leaflet v2.2.0 on Tuesday, August 29 at the latest and are hoping we can have all reverse dependencies issues worked out by then. Thanks!

netlify[bot] commented 1 year ago

Deploy Preview for leaflegend canceled.

Name Link
Latest commit 0373b9df42e6cf7718281d691139b340746d84bd
Latest deploy log https://app.netlify.com/sites/leaflegend/deploys/64db72f2de51a40008e6db0b
tomroh commented 1 year ago

@gadenbuie I'll publish to CRAN within the next week

gadenbuie commented 1 year ago

Great, thank you! If you don't mind leaving a comment here when it's accepted, that would be much appreciated :smile:

tomroh commented 1 year ago

It's on it's way to CRAN now.