search

tomshanley / d3-sankey-circular

A fork of the d3-sankey library to allow circular links.
MIT License
89 stars 41 forks source link

micah/18/bundle with rollupjs #19

Closed micahstubbs closed 6 years ago

micahstubbs commented 6 years ago

This PR adds a umd and es-modules build to d3-sankey-circular. This should make the library easier for people to use in more varied environments.

To accomplish this, we use javascript bundler rollup and transpiler babel.

steps to test

cd d3-sankey-circular

# checkout this PR locally
# more https://help.github.com/articles/checking-out-pull-requests-locally/
git fetch origin pull/19/micahstubbs:micah/18/bundle-with-rollupjs
git checkout micah/18/bundle-with-rollupjs

npm install
npm run build

# run a local webserver
live-server

then, visit the examples page to verify that the example renders and works https://localhost:8080/example

tomshanley commented 6 years ago

Hi Micah - thanks for this. I'm not how to test this, so happy to accept (ie i trust you)

micahstubbs commented 6 years ago

@tomshanley you're kind. will add steps to test, and comments about the things I'm not quite happy with yet.

the build with rollup is working now, but the way I setup the moduleName isn't quite right yet 🤔