tomshanley / d3-sankey-circular

A fork of the d3-sankey library to allow circular links.
MIT License
89 stars 41 forks source link

micah/21/eslint #22

Closed micahstubbs closed 6 years ago

micahstubbs commented 6 years ago

This PR adds eslint to help catch errors and make it easier for new people to contribute to the project 😄 https://eslint.org/docs/about/

I followed this getting started guide and picked a default config for a browser project that does not use JSX. https://eslint.org/docs/user-guide/getting-started

usage

npm install

# to check for linting errors
npm run lint

# to check for linting errors
# and automatically fix many of them ✨
npm run lint:fix
micahstubbs commented 6 years ago

@tomshanley overall this was pretty straightfoward. normally new codebases have a lot more linting errors. this one was already pretty clean 😄

micahstubbs commented 6 years ago

@tomshanley these default rules are just a starting point - you can modify the linting config anytime you like by editing the .eslintrc.json config file https://eslint.org/docs/user-guide/configuring