search

tomshanley / d3-sankey-circular

A fork of the d3-sankey library to allow circular links.
MIT License
89 stars 41 forks source link

Add support for update() #28

Closed antoinerg closed 5 years ago

antoinerg commented 5 years ago

Dear @tomshanley, first of all, thank you for the great library!

One feature that I was missing from d3-sankey is update(). It is useful when you want to recompute the position of the links after the nodes are repositioned interactively. This is feature is implemented back in with the current PR.

Thank you!

antoinerg commented 5 years ago

@tomshanley Thank you for merging my changes! I was wondering if you will release a new version of the d3-sankey-circular npm package containing the update? If so, I would love to add it as a dependency to my project.

Thank you again :smile_cat:

tomshanley commented 5 years ago

Hi Antoine - once I'm back from holiday I'll do that. Glad you're getting some use from the library!

tomshanley commented 5 years ago

Hi Antoine - I've updated the npm to v 0.30.0. let me know if something hasn't worked properly. I use npm about once a year, so i always forget something