search

tomshanley / d3-sankey-circular

A fork of the d3-sankey library to allow circular links.
MIT License
89 stars 41 forks source link

Self linking links don't always follow the top/bottom setting for the node #5

Closed tomshanley closed 6 years ago

tomshanley commented 6 years ago

Where a node links back to itself, the link should follow the top/bottom setting for the node. This isn't always happening

tomshanley commented 6 years ago

2 approaches - try to correct all links for nodes, but this will end up with a lot of links in the top or bottom, and not evenly balanced. Or just move the self linking ones. I will try this approach first

tomshanley commented 6 years ago

Added check to end of the function that assigns top/bottom, to confirm that links are a) self-linking, or b) link two nodes with the same type then they have same the same type as the node

tomshanley commented 6 years ago

To include in next release