search

tomslee / airbnb-data-collection

Data collection for Airbnb listings.
MIT License
478 stars 183 forks source link

exception missing #20

Closed nadavbi closed 6 years ago

nadavbi commented 7 years ago

Function add_survey_log_bb_table in schema_update.py is missing an exception as part of the Try function, This leads to unexpected unindent error

tomslee commented 7 years ago

Hi nadavbi: sorry about that. I believe it is fixed now. The perils of developing on the master branch: I will try to avoid doing so in future.

nadavbi commented 7 years ago

Hey, schema_update.py is still unfixed. Thanks for the response!

tomslee commented 7 years ago

My bad. Can you try again please? Unfortunately I don't have a good test setup for schema changes...

nadavbi commented 7 years ago

This worked, but apparently this wasn't the source of the error I was getting (all of my schemas are updated) I get a bunch of errors when beginning the bounding box method in the type of:

rectangle = self.bounding_box[0:4] TypeError: 'NoneType' object is not subscriptable

I will mention that that the bounding coordinates are entered and I've been using this method for a while. It's just since I tried the updated the code that this error exists

tomslee commented 7 years ago

I'll take a look this evening. I've been using it for a while before checking in changes so it works for me, but obviously we have things set up slightly differently.

tomslee commented 7 years ago

I am not seeing anything obvious about why self.bounding_box can end up as None. Do you think you could run it again like this to get debug output: python airbnb.py -sb NNN -v and then attach the log file to the issue, or email it to me at tom at tomslee dot net if you prefer.