search

tomsmalley / semantic-reflex

🔧 Semantic UI for Haskell and Reflex-DOM
https://tomsmalley.github.io/semantic-reflex/
BSD 3-Clause Clear License
38 stars 13 forks source link

Fix export collision #47

Closed alexfmpe closed 2 years ago

alexfmpe commented 2 years ago

After some package set bumping I ran into

    Conflicting exports for ‘SetValue’:
       ‘module Components’ exports ‘Components.SetValue’
         imported from ‘Reflex.Dom.SemanticUI.Transition’ at src/Reflex/Dom/SemanticUI.hs:38:1-53
         (and originally defined
            at src/Reflex/Dom/SemanticUI/Transition.hs:505:1-35)
       ‘module Reflex’ exports ‘Reflex.SetValue’
         imported from ‘Reflex.Dom.Builder.Class’ at src/Reflex/Dom/SemanticUI.hs:41:1-62
  |
5 |   , module Reflex
  |     ^^^^^^^^^^^^^

Probably triggered by https://github.com/reflex-frp/reflex-dom/commit/b9d7914b0166ce6c01ce98fb2a434e628e45c965. I'd expect this hiding to fail with a reflex-dom prior to the above change, but nix-build -A ghc.semantic-reflex-example of this PR works, so I guess CPP isn't needed?

tomsmalley commented 2 years ago

I don’t mind the lack of CPP - anyone using older reflex-dom can stay on the current version of semantic-reflex.

Thanks!