search

tomsmalley / semantic-reflex

🔧 Semantic UI for Haskell and Reflex-DOM
https://tomsmalley.github.io/semantic-reflex/
BSD 3-Clause Clear License
38 stars 13 forks source link

Match the record style of upstream #6

Closed tomsmalley closed 6 years ago

tomsmalley commented 6 years ago

Instead of _buttonColor we should probably have _button_color. Upstream would dictate _buttonConfig_color but I think that's too verbose.

roberth commented 6 years ago

The upstream convention does let you disambiguate between inputs and outputs easily and it'd be more consistent.

tomsmalley commented 6 years ago

True. I suspect I would regret button_color down the line, having thought about it. Consistency is important!

tomsmalley commented 6 years ago

Fixed as of 1df75c0751b0a429360982bda08ea7cf4f24071a