tomsom / yoga-linux

Run Linux on the Lenovo Yoga 7 14 (14ARB7) with AMD Ryzen 6800U (Rembrand).
https://github.com/tomsom/yoga-linux/wiki
58 stars 1 forks source link

Internal keyboard not working with newer Kernels #47

Closed Akinzekeel closed 1 year ago

Akinzekeel commented 1 year ago

So I recently decided to test the new kernel 6.4 which is now no longer listed as RC / experimental. I was hoping for some AMD CPU enhancements among other things.

Unfortunately my excitement was quickly hampered when I found that after rebooting into the new kernel, the keyboard did not work at all and I was unable to even log in. I could still use the touchpad as well as external USB keyboards, but the internal keyboard didn't do anything. After reverting back to 6.3, I then tried 6.5-rc1 and I had the same problem.

I could not find much information on this so it does not seem to be a widespread issue. Any ideas how I could troubleshoot this? Or does someone else have this problem?

(tested on Manjaro Gnome & KDE versions)

Myaats commented 1 year ago

Works fine for me on 6.4.4 (NixOS), likely distro or setup related. I recommend grepping the kernel logs for i8042 if you decide to attempt to reproduce.

0x9fff00 commented 1 year ago

I can reproduce on 6.5-rc3 but not 6.4.6. Likely related to https://github.com/torvalds/linux/commit/a9c4a912b7dc7ff922d4b9261160c001558f9755 which reverted https://github.com/torvalds/linux/commit/9946e39fe8d0a5da9eb947d8e40a7ef204ba016e (the old keyboard fix from 6.0). Manjaro includes it in their 6.4 kernel: https://gitlab.manjaro.org/packages/core/linux64/-/blob/master/0201-ACPI-resource-Remove-Zen-specific-match-and-quirks.patch

Edit: I've confirmed this and will send a regression report

0x9fff00 commented 1 year ago

See https://lore.kernel.org/all/596b9c4a-fb83-a8ab-3a44-6052d83fa546@augustwikerfors.se/ and https://lore.kernel.org/all/5fbe6ee8-f907-ffec-7c6d-400aa74eaf20@augustwikerfors.se/

Akinzekeel commented 1 year ago

Thanks for your research. That would explain it.

So I guess the only 2 options from here are

  1. Wait for a kernel patch
  2. Restore the commit and build the kernel myself

As I have 0 experience with the 2nd option I will probably just wait for some update.

0x9fff00 commented 1 year ago

Kernel Bugzilla report: https://bugzilla.kernel.org/show_bug.cgi?id=217718

rodude123 commented 1 year ago

Can you not just reapply the original patch and compile the kernel yourself?

0x9fff00 commented 1 year ago

This is the patch sent upstream: https://lore.kernel.org/all/20230728191408.18141-1-mario.limonciello@amd.com/

George-Spanos commented 1 year ago

I can verify that 6.4.7 for me makes keyboard unsuable.

OS: Fedora 38 with KDE Device: lenovo yoga 7 14arb7

6.4.4 and 6.4.6 work just fine.

zerosign commented 1 year ago

Hi, it's seems 6.4.7 also doesn't work either in Yoga Slim 7 proX 14ARH7 (or maybe all lenovo notebook zen 3 in that being sell/manufactured on that year). Should I also report this to bugzilla.kernel.org directly ?

System Information
        Manufacturer: LENOVO
        Product Name: 82TL
        Version: Yoga Slim 7 proX 14ARH7
0x9fff00 commented 1 year ago

@zerosign Yes please do so

George-Spanos commented 1 year ago

Just updated to 6.4.9 and the keyboard seems to work.

OS: Fedora 38 with KDE Device: lenovo yoga 7 14arb7 Kernel version: 6.4.9-200.fc38.x86_64

0x9fff00 commented 1 year ago

Fedora reverted https://github.com/torvalds/linux/commit/a9c4a912b7dc7ff922d4b9261160c001558f9755 in their downstream kernel. That revert along with patches to avoid regressions for other models will be in 6.5-rc6 and likely in an upstream 6.4 stable release next week. For details see https://lore.kernel.org/all/20230809085526.84913-1-hdegoede@redhat.com/T/ and https://bugzilla.redhat.com/show_bug.cgi?id=2229165

stuarthayhurst commented 1 year ago

It seems this has also made it to the mainline kernel now, ready for the next release candidate (rc6?)

lamarios commented 1 year ago

Seems like it works for me on fedora with kernel 6.4.9.it was released today.

EnderMk9 commented 1 year ago

Yup, I can confirm that on 6.4.9 in fedora it's fixed

rodude123 commented 1 year ago

what about on arch?

Akinzekeel commented 1 year ago

I tried 6.4.10.arch1-1 today on Endeavour but the keyboard still didn't work

0x9fff00 commented 1 year ago

Looks like 6.4.11 will be released with the fix on Tuesday or Wednesday: https://lore.kernel.org/all/20230813211724.969019629@linuxfoundation.org/

zerosign commented 1 year ago

I see the changes are being reverted back based on this patches https://lore.kernel.org/all/20230813211725.649477976@linuxfoundation.org/

stuarthayhurst commented 1 year ago

Confirmed working with upstream 6.5-rc6, can this be closed?

0x9fff00 commented 1 year ago

Also fixed in 6.4.11

Akinzekeel commented 1 year ago

I can't find 6.4.11 on any of my machines and 6.5-rc6 fails to install ("problem importing keys")

Akinzekeel commented 1 year ago

After some more troubleshooting, I managed to install kernel 6.5-rc6 and I can confirm that the keyboard works.

Update: I can also confirm that 6.4.11 works