Dockerfile tests - Githubissues

tomsquest / docker-radicale

Docker image for Radicale calendar and contact server :calendar: + security :closed_lock_with_key: + addons :rocket:

GNU General Public License v3.0

562 stars 80 forks source link

Dockerfile tests #28

Closed robertbeal closed 6 years ago

robertbeal commented 6 years ago

I've started a small suite of tests for the Dockerfile, mainly to ensure we don't break anything and allows us to test-drive any changes we make

robertbeal commented 6 years ago

(note - not sure how easily it'll integrate with travis, may need some tweaking)

robertbeal commented 6 years ago

Will need to squash the commits as it's taken a bit of tweaking to get it passing on travis

tomsquest commented 6 years ago

Nice idea, Robert!

Holidays here. I will try to get some time to give a try to the PR.

On August 17, 2018 1:35:54 PM GMT+02:00, Robert Beal notifications@github.com wrote:

Will need to squash the commits as it's taken a bit of tweaking to get it passing on travis

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/tomsquest/docker-radicale/pull/28#issuecomment-413838428

-- Thomas Queste

tomsquest commented 6 years ago

Hi @robertbeal ,

I have started to read and test your PR. I am merging it.

Next, I may try to:

switch to pipenv (which I use locally), hence dropping the requirements-test.txt and adding the Pipfile files. This would also require to update the travis.yml according to https://pipenv.readthedocs.io/en/latest/advanced/#travis-ci
adding this test: changing the UID/GID, so testing that the radicale process is run by this user