search

tomsquest / docker-radicale

Docker image for Radicale calendar and contact server :calendar: + security :closed_lock_with_key: + addons :rocket:
GNU General Public License v3.0
591 stars 82 forks source link

Feature request: support UMASK environment variable #93

Closed Miwer closed 2 years ago

Miwer commented 3 years ago

Hi,

It would be great if the docker-entrypoint.sh could support providing a UMASK variable, and set this using the umask command before running radicale. Currently data files created by this image is readable by "all", but I would like to use umask 027, so only owner/group ID is able to read the data files.

Thanks ;)

tomsquest commented 3 years ago

Hi @Miwer , That could be a good feature. Do you have a Docker image that do so?

Miwer commented 3 years ago

Do you have a Docker image that do so?

Not exactly. I made a wrapper script in my bind volume, and replaced the entrypoint to call that script instead, which sets the umask and then executes the original docker-entrypoint.sh afterwards.

But all that needs changing would be the docker-entrypoint.sh to check for the presence of an environment variable, and run umask before the radicale service.

tomsquest commented 3 years ago

PR welcome, don't forget to add an integration tests.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 2 years ago

This issue was closed because it has been stalled for 14 days with no activity.