search

tomstewart89 / BasicLinearAlgebra

A library for using matrices and linear algebra on Arduino
MIT License
185 stars 38 forks source link

Streaming library compatibility #79

Closed insalt-glitch closed 3 months ago

insalt-glitch commented 3 months ago

Resolves #74. I did a simple implementation of what we discussed in the connected issue. The examples are now modified to use the default Arduino printing in combination with the Printable-interface. I'm not sure if this is still up-to-date, for now I left it in:

https://github.com/insalt-glitch/BasicLinearAlgebra/blob/db7ed349b76b284f7b3dd8608da1a68ba24fb60e/examples/HowToUse/HowToUse.ino#L93-L95

I checked that it compiles on in the Arduino IDE and all is well! The only potential issue I encountered is that my language-server was freaking out. Maybe @tomstewart89 or @twrackers can confirm or deny this? While it does not hinder the compilation, it may be annoying to work with. I'm unsure what the problem is though...

In any case, let me know what you think!

tomstewart89 commented 3 months ago

Seems to work well! Let's merge this guy :+1: . I didn't have any trouble with my language server so no problems there! Just for my reference, what did you mean with regards to these lines?

Thanks again for the PR! I really appreciate all the effort you've put in to this repo lately!

insalt-glitch commented 3 months ago

Seems to work well! Let's merge this guy 👍 . I didn't have any trouble with my language server so no problems there! Just for my reference, what did you mean with regards to these lines?

Thanks again for the PR! I really appreciate all the effort you've put in to this repo lately!

I'm happy to put in the work, I like the simplicity of the library you have built :). I was just curious whether these lines are still appropriate/what they mean? Since the statement shown is the same as you would expect it with any other print-like function: The statement (...) will be evaluated first, then the function will be called with the result. Don't worry about it, maybe it is not obvious to everyone that this can be done 👍.