search

tomtaborsky / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

Use camelCase or -/_ for multi-word names #2

Open griffinlacek opened 7 years ago

griffinlacek commented 7 years ago

Common practice is to keep classnames and ids in camelCase or -/_ format, which means all one word names are lowercase and if there are more than two words then we do camelCase, which keeps the first word lowercase and capitalizes the first letter of each following word. Alternatively, we can separate words with - or . A few of your classes and ids are just one word with capital letters or have multiple words with no camelCase or -/.

Here's just a few spots:

https://github.com/tomtaborsky/f1-3-c2p1-colmar-academy/blob/master/ColmarSchool/index.html#L45 https://github.com/tomtaborsky/f1-3-c2p1-colmar-academy/blob/master/ColmarSchool/index.html#L47 https://github.com/tomtaborsky/f1-3-c2p1-colmar-academy/blob/master/ColmarSchool/index.html#L55 https://github.com/tomtaborsky/f1-3-c2p1-colmar-academy/blob/master/ColmarSchool/index.html#L71 https://github.com/tomtaborsky/f1-3-c2p1-colmar-academy/blob/master/ColmarSchool/index.html#L147 https://github.com/tomtaborsky/f1-3-c2p1-colmar-academy/blob/master/ColmarSchool/index.html#L218

tomtaborsky commented 7 years ago

Thank you for that comment! I will do this in the future. When choosing names I've oriented myself with Codecademy lessons, so maybe this should be changed in the lessons as well.