search

tomteman / attendr

An Ethereum decentralized application that helps event organizers prevent no-shows by requiring attendees to make a deposit into a smart contract in order to gain entrance to the event. Deposits are refunded upon arrival (by scanning the wallet address QR code). All funds of no-shows are transferred to a charity wallet address defined in the contract in advance.
https://attendr.io
2 stars 6 forks source link

Optimize and add features to EventStorage contract #1

Closed tomteman closed 6 years ago

tomteman commented 6 years ago
  1. Update contract code style to latest solidity specifications
  2. Optimize contract performance
    1. replace return as code breaks with assert statements
    2. Remove name from Attendee object and all relevant methods in the contract and update frontend app so it will not be required (in the future - to be saved off chain). List of attendees should return the addresses.
    3. Currently, all funds of all events are stored together in the contract - this should be improved, as it is probably a security concern.
    4. Find and fix additional inefficiencies
gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.15 ETH (106.67 USD @ $711.11/ETH) attached to it.

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 6 months, 3 weeks ago. Please review their action plans below:

1) dilatebrave has started work.

i will look into this

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 6 years ago

@dilatebrave Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

dilatebrave commented 6 years ago

@gitcoinbot -- i still working on this issue. Just got some problem when compiling but it's ok now. I hope i can finish it soon

gitcoinbot commented 6 years ago

@dilatebrave. :wave: thanks for the atMention, but you need to install @gitcoinbot on this repo for me to be able to respond. More details in the documentation.

:v: @gitcoinbot

dilatebrave commented 6 years ago

@tomteman --- it looks like the current codebase got a critical bug on deposit value. I think we should store the deposit value as wei in contract, the frontend will convert to eth when display

vs77bb commented 6 years ago

@dilatebrave @tomteman snoozing Gitcoin Bot for 3 days here

vs77bb commented 6 years ago

Hi @dilatebrave @bakoah How is this and #3 going? Just checking in, hope all is well 🙂

dilatebrave commented 6 years ago

@vs77bb - i've done all the requirements but still waiting for @tomteman 's repsonse my last commit at PR #5

gitcoinbot commented 6 years ago

@dilatebrave Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.15 ETH (74.01 USD @ $493.4/ETH) has been submitted by:

  1. @dilatebrave

@tomteman please take a look at the submitted work:

tomteman commented 6 years ago

@dilatebrave sorry it took so long to merge your PR, the past two weeks have been pretty crazy. I sincerely apologize you had to wait so long, and I really hope it won't deter you from working with me again in the future, I assure you this isn't how I usually operate 😅

gitcoinbot commented 6 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.15 ETH (65.53 USD @ $436.85/ETH) attached to this issue has been approved & issued to @dilatebrave.