search

tomthecarrot / arcore-for-all

Google ARCore (dev preview 1) for "unsupported" Android devices
GNU General Public License v3.0
1.04k stars 145 forks source link

ARCore Preview v2 #114

Open vdbo opened 6 years ago

vdbo commented 6 years ago

Hello there :)

At first I want to say thank you for providing Google's ARCore library which can be installed on other devices. Great job 👍 And are you planning to make the new build with ARCore v2 preview?

Thanks in advance

tomthecarrot commented 6 years ago

@vdbo Thank you for your support! It would be great for this repo to be compatible with ARCore v2, but I have not yet had time to test it on the v2 library. Please feel free to research, collaborate, and make modifications to support v2! PRs are welcome :)

Torbilicious commented 6 years ago

Hi! I am interested in helping here. @tomthecarrot could you explain what exactly you did for v1?

tomthecarrot commented 6 years ago

Thanks @Torbilicious! I detailed the process in the README at the root of this repo. Happy to answer any questions about the process, just let me know! :)

almozavr commented 6 years ago

Had a quick look on decompiled sources: looks like there is no plain java class for supported devices, instead Session has native method wrapped with javish isSupported -> so we have to re-compile this class with android sources linked to the process

vdbo commented 6 years ago

@almozavr totally right! A support for device is checked in Session class, but it seems like it's the fundamental class. So how do you think, is there any possibility that we can break down some functionality during decompilation?

almozavr commented 6 years ago

The method we are looking for is a dead simple oneliner, but I haven't checked imports yet, so not sure if everything is linkable

beijibeijing commented 6 years ago

How is it going?My device is s8+,and I have try it,but it doesn't work.

Torbilicious commented 6 years ago

I followed your steps for the v1 library but when trying to recompile the changed (now called Session) class i got a whole bunch of errors.

pastebin

All the classes that it says are missing can be found (Config, Anchor, Frame, ...). Can anyone make something of those errors?