tomthecarrot / arcore-for-all

Google ARCore (dev preview 1) for "unsupported" Android devices
GNU General Public License v3.0
1.04k stars 145 forks source link

WebARonARCore #40

Open MakeHorizont opened 7 years ago

MakeHorizont commented 7 years ago

hello guys, how about https://github.com/google-ar/WebARonARCore

how i may use this with "arcore-for-all"?

thanks

Horsetopus commented 7 years ago

From what I read it uses the Same ARCore service. It doesn't embed it or anything.

So if your device fails with the samples, telling you "Tango core has stopped", WebARonARCore isn't likely to work either.

Now if the samples work, and you want to run WebARonARCore, you will have to:

Then hopefully you might have a build of WebARonARCore that works for you.

aman-tiwari commented 7 years ago

I just did the above, the apk is at: https://drive.google.com/file/d/0B-7CCAaMeqWDN2xpR2E2ZldOaEk/view?usp=sharing

The patch required is: https://gist.github.com/aman-tiwari/66df4950531f04138b37cb6eca4efa6c

index df7f8cb..46cdd7b 100644
--- a/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java
+++ b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java
@@ -429,7 +429,7 @@ public class AwShellActivity extends Activity implements OnRequestPermissionsRes
         super.onCreate(savedInstanceState);

         // If the device is not supported, show an alert and quit.
-        if (!SupportedDevices.isSupported(this)) 
+        if (false) 
         {
             createAlertDialog(AwShellActivity.this, "ERROR", "This device is not currently supported by WebARonARCore.", new DialogInterface.OnClickListener()
                 {

It seems to work on my Nexus 6P. The tracking sucks at the start but seems to get good after a 10-20 seconds of looking around.

UDXS commented 7 years ago

Can someone convert this apk to work with below Android 7 using the method in #70