search

tomtom-international / jsl

TomTom Jenkins Shared Library
Apache License 2.0
6 stars 6 forks source link

feat: Make build, lint and test commands customizable #18

Closed nullJaX closed 4 years ago

nullJaX commented 4 years ago

These changes aim to make shared library more customizable for projects based on setup.py tool. It allows to execute build, lint and test stages with custom parameters (that would be defined differently for each project). In addition, developers are allowed to utilize intermediate CLI scripts to filter tasks that are specific for a project.

eugene-davis commented 4 years ago

Hi @nullJaX can you update jsl/vars/pythonSetupPyPipeline.txt with your new parameters? Also it may help to provide the use case in the description, (e.g. the alternative commands you are using)

Finally, I added "feat:" to the start of your PR for you so that the Semantic Pull Request check will pass.

nullJaX commented 4 years ago

These changes aim to make shared library more customizable for projects based on setup.py tool. It allows to execute build, lint and test stages with custom parameters (that would be defined differently for each project). In addition, developers are allowed to utilize intermediate CLI scripts to filter tasks that are specific for a project.

martinm82 commented 4 years ago

I am fine with the changes as they are still backwards compatible. But I think the ultimate solution would be to rewrite or actually create a new one that would be for example Makefile based.

Basically we would define a Makefile interface with various targets that projects could define on their own and therefore serve various projects not only Python based ones.

martinm82 commented 4 years ago

Do not merge until changes got validated

nullJaX commented 4 years ago

Validated. working