search

tomtom / quickfixsigns_vim

Mark quickfix & location list items with signs
http://www.vim.org/scripts/script.php?script_id=2584
GNU General Public License v3.0
131 stars 13 forks source link

Refactor quickfixsigns#vcsdiff#GetList #65

Closed blueyed closed 8 years ago

blueyed commented 8 years ago

Previously calling quickfixsigns#vcsdiff#GetList() would not set the cache.

Also add a quickfixsigns#vcsdiff#ClearCache() API.

tomtom commented 8 years ago

Could you please explain your PR. What are these s:UNSET_* vars. Where are they set?

blueyed commented 8 years ago

The s:UNSET_* vars are sentinel instances to be able to "unlet" lists/strings (by setting them to this value), since apparently Vim does not support unlet for another buffer without side-effects of :bufdo / :b.

This PR fixes an issue where the cache was not used correctly, and provides an API to clear it. This is useful for statusline plugins etc.

tomtom commented 8 years ago

I still don't see, where this vars are ever set.

blueyed commented 8 years ago

At the top: https://github.com/tomtom/quickfixsigns_vim/pull/65/files#diff-896ddaeeacf00191a6ef8d0b436c6441R21

tomtom commented 8 years ago

Ok, now I understand.