tomtom / tlib_vim

Some utility functions for VIM
http://www.vim.org/scripts/script.php?script_id=1863
GNU General Public License v3.0
173 stars 43 forks source link

Latest commit of tlib breaks snipmate #24

Closed marcusboon closed 7 years ago

marcusboon commented 7 years ago

Updated tlib to version 1.23 and it breaks snipmate with a Error detected while processing /home/marcus/.vim/bundle/vim-snipmate/autoload/snipMate.vim: line 9: you're missing tlib. See install instructions at /home/marcus/.vim/bundle/vim-snipmate/README.md Press ENTER or type command to continue

Reverting back to 1.22 solves the issue.

craigmaloney commented 7 years ago

Reason being is tlib 1.23 has a version check in World.vim for Vim 8.0. So it looks like vim 7 is no longer working with the latest change.

craigmaloney commented 7 years ago

Error detected while processing /home/craig/configs/vim/bundle/tlib_vim/autoload/tlib/World.vim: line 8: tlib: VIM >= 8.00 is required Error detected while processing function tlib#input#List: line 16:

tomtom commented 7 years ago

Well yes, tlib >= 1.23 requires VIM 8 or higher. The reason is that it now makes use of the new winid-related functions. I could try to imitate this behaviour for VIM 7 but this isn't a high-priority goal for me.

Version 1.22 should still work well in conjunction with snipmate.

Are you stuck with vim 7?

craigmaloney commented 7 years ago

Until I can upgrade to a later version of Ubuntu (currently at 14.04) I'm stuck at Vim 7.4. I believe this is the case for 16.04 as it doesn't ship with Vim 8 and there's no PPA support that I'm aware of.

taq commented 7 years ago

This is affecting also Neovim users, as Neovim is returning the 704 version with v:version. I fixed it checking if we are really using Vim and checking for version like this:

if v:progname == 'vim' && v:version < 800
    echoerr 'tlib: VIM >= 8.00 is required'
    finish
endif

Can we use that way or is there some better way to do that?

tomtom commented 7 years ago

This is affecting also Neovim users

Neovim doesn't support lambdas either, does it?

craigmaloney commented 7 years ago

Thank you. Verified that this works again.

taq commented 7 years ago

@tomtom seems that it does not support lambdas - yet - but are working on it.

yann-morin-1998 commented 7 years ago

Indeed, this fixes garbas/vim-snipmate#246

Thanks!