Closed jcbrill closed 3 years ago
This pull request contains the minimum localized preprocessor changes to allow building dcrawps with msvc on windows.
On windows, it can be useful to compile with both mingw-w64 and msvc as sometimes they each report issues that the other does not.
Mingw-w64 defines more WIN32-like symbols than msvc:
__WIN32
__WIN32__
_WIN32
WIN32
Note: unlike gcc, I am unfamiliar with a way to dump the pre-defined macros for msvc. The msvc symbol above was taken from the online documentation.
Depending on which compilers are supported on windows, there may be minor opportunities to revise some of the existing preprocessor tests.
dcrawps command-line build tests on windows for this PR:
Looks good, thank you.
This pull request contains the minimum localized preprocessor changes to allow building dcrawps with msvc on windows.
On windows, it can be useful to compile with both mingw-w64 and msvc as sometimes they each report issues that the other does not.
Mingw-w64 defines more WIN32-like symbols than msvc:
__WIN32
__WIN32__
_WIN32
WIN32
_WIN32
Note: unlike gcc, I am unfamiliar with a way to dump the pre-defined macros for msvc. The msvc symbol above was taken from the online documentation.
Depending on which compilers are supported on windows, there may be minor opportunities to revise some of the existing preprocessor tests.
dcrawps command-line build tests on windows for this PR: