Closed amberhinds closed 11 months ago
Thanks for looking into this, @amberhinds 🙌 You are THE BEST!
@amberhinds thank you, We will work to improve this on our next release.
@amberhinds I've opened a PR in our GBP repo that should address all of this. Any chance you can shoot us an email so I can send you the new code for review?: support@generateblocks.com
Most of these only required us to create default custom HTML attributes when adding a new Tabs block (the fix won't apply to those already created, however users can add these roles via the custom HTML attributes feature).
The aria-controls
issue requires setting IDs on your "Tab Item" containers. If the system recognizes IDs on those containers, it will automatically use aria-controls
. This is in the current version.
We've replaced aria-expanded
with aria-selected
.
Thank you again! Really appreciate your help.
These improvements have been merged in GBP 1.7.0, which is the next Pro release.
Thanks!
Thanks for making accessibility improvements a priority, @tomusborne! 💪
Description
The tabs block is missing the necessary ARIA attributes and to make it accessible for screen reader users.
Current Code
This is the HTML that I saw for the block when testing.
Expected behavior
This is a high-level summary of what is missing to make this block accessible:
References:
Here are some references to help: