search

tomusborne / generateblocks

GenerateBlocks is a small collection of lightweight WordPress blocks that can accomplish nearly anything.
https://generateblocks.com
188 stars 18 forks source link

Feature: Add pattern library to plugin sidebar #1176

Closed tomusborne closed 5 months ago

tomusborne commented 5 months ago

Alternative to #1175

https://github.com/tomusborne/generateblocks/assets/20714883/d37d2a4f-3f03-471e-8cc5-c64a875c25be

Did this as a quick alternative to using a portal to insert the Pattern Library block.

This has the advantage of using core features to add the toggle (no portal needed).

However, it has the disadvantage of not being as obvious/visible.

Nice thing here is that if markup changes, the button will remain there and it will open a regular plugin sidebar with a button to open the library.

dgwyer commented 5 months ago

Looks like folks (from GB Discord channel) are favoring this approach over #1175 so we should probably go with this version. Only other minor point is if we stick with the current icon or swap it out for the GB icon?

tomusborne commented 5 months ago

Yea, the icon is something we need to figure out. Will get a few ideas on it. Let's merge this for now anyway.