tomusborne / generateblocks

GenerateBlocks is a small collection of lightweight WordPress blocks that can accomplish nearly anything.
https://generateblocks.com
198 stars 23 forks source link

2.0a Icons are missing the fill color property #1491

Open Kovas opened 5 days ago

Kovas commented 5 days ago

The CSS property fill: currentColor; is missing from the icon styles, which prevents some icons from inheriting the correct color.

tomusborne commented 3 days ago

Hey @Kovas,

Are you saying that some of our default icons are missing the fill="currentColor" HTML attribute, or that our styles system is missing a fill option?

Kovas commented 3 days ago

What I’m saying is that the pre–2.0 class for the icon included fill: currentColor: .gb-icon svg { width: 1em; height: 1em; fill: currentColor; } However, this is missing in the current version: .gb-shape svg { width: 1em; height: 1em; } As a result, since the color picker applies color instead of fill, some icons (e.g. copy/paste from FontAwesome) retain their default color.