search

tomusborne / generatepress

453 stars 89 forks source link

Dark mode #534

Open tomusborne opened 1 year ago

tomusborne commented 1 year ago

We should look at what's needed to add a dark mode feature.

diggeddy commented 1 year ago

Theres a good topic here relating to color swapping for darkmode, and the OPs JS Fiddle is still live and covers the basics: https://generatepress.com/forums/topic/is-it-possible-to-fire-generate_element_display-using-wp-hooks/#post-2179091

However this is not a simple plug and play feature. There is more than colors to be considered.

Lets discuss.

SchneiderSam commented 1 year ago

Why not Style Variations? Check out https://make.wordpress.org/core/2022/05/03/global-styles-variations-in-wordpress-6-0/

example: https://wordpress.org/themes/spectra-one/

I know this has to do with FSE, but why tinker with old techniques when there will soon be much better solutions?

Ghazi3 commented 1 year ago

GeneratePress is light and fast, and this is what makes me use it in projects always, whether for my own projects or my clients' projects The dark mode is added as an option for the visitor, which I think is very important Many customers request this thing, and when using the plug-in it causes slowness, and this is very annoying. I used a lot of plug-ins, but they are all bad

I hope you seriously consider adding this feature to GeneratePress

oicurmt3 commented 10 months ago

There are plugins that do this quite well and most browsers also have this feature. Similar to @SchneiderSam if anything, I'd like to see an assortment of downloadable colour palettes that can be applied within the customiser.

jrgong420 commented 1 day ago

Bumping this one, it would be great addition