search

tomusborne / generatepress

450 stars 89 forks source link

The Default Cart and Checkout Blocks in WooCommerce Are Incompatible with GP (+GPP) #594

Open FunkyCss opened 8 months ago

FunkyCss commented 8 months ago

The new WooCommerce sites come with default Cart and Checkout blocks embedded in the page. However, there's an issue with these blocks—they don't inherit the settings from GP Premium, such as customizer settings, phone and address details, distraction-free checkout, hidden inputs, and more.

Moreover, the buttons in these blocks have their own styles, and changing them requires CSS modifications.

Another observation is that the Checkout block doesn't adhere to the padding settings of the GeneratePress theme on mobile devices. It seems like it doesn't recognize the container.

This situation makes GeneratePress, especially with the latest WooCommerce update, not the most suitable choice for such websites. In fact, it seems to be non-functional.

If you need assistance with testing or require images, please let me know.

tomusborne commented 3 months ago

Hey @FunkyCss,

Yes, WooCommerce blocks have completely changed their HTML structure and class names, which makes it so some of our WooCommerce options only apply to the "Classic" WooCommerce blocks. We're fixing some of these issues in GPP 2.5.0, but not all of them are simple fixes, unfortunately.

Another observation is that the Checkout block doesn't adhere to the padding settings of the GeneratePress theme on mobile devices. It seems like it doesn't recognize the container.

This is because the new Woo blocks all set the alignment option to "Align Wide". I have no idea why they decided to make this the default.

FunkyCss commented 3 months ago

Hi @tomusborne,

Thank you for the update. I noticed some of the pull requests you are working on today, which is great.

I understand that this process is not very easy, and I am curious why all new WooCommerce installations default to using these blocks. This change can be problematic for GeneratePress and other "hybrid" themes. WooCommerce does not seem fully ready for this type of block change, yet it is being pushed forward.

But really I appreciate the idea of keeping GP & GB as close to the WP core as possible.

Thank you again for your update. I hope the new GP updates will find a good solution for e-commerce stores, as the performance benefits of GP are greatly appreciated by many store owners.